[Bug 273461] [NEW PORT] irc/unreal current version of unrealircd

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 08 Sep 2023 03:18:50 UTC

--- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  TPlease remember to tick the "patch" box when
attaching patches so they can be viewed on bugzilla.

This port looks very good already.  Here are some notes on your port:

 - we got rid of "Created by" lines a while ago.  New such lines will not be
   accepted.  Please remove the line from the Makefile.
 - check if you can use USES=localbase instead of manually adding localbase
 - ${DATADIR} should not be used for writable data or temp files.
   Please place such data in accordance with hier(7).  For example,
   using /var/cache for caching and /tmp or /var/tmp (or a subdirectory of
   these) for temporary files may be a good idea.
 - why do you install source files with shared objects into the lib/unreal?
   Is this intentional?
 - for config files, please check if you can use the @sample mechanism (cf.
   ยง8.3 Porter's Handbook).  If you don't use it, package updates may kill
   the user's configuration changes.
 - upstream is no longer dead, is it?  Is -fcommon still required?
 - ${MKDIR} should not fail if the directory already exists as it expands to
   mkdir -p.  So || true is not required and could mask important errors.
 - please move the installation commands for docs into do-install-DOCS-on, so
   they are only executed when DOCS is enabled
 - there's no reason to put doc subdirectory into DOCSDIR.  It is already clear
   that DOCSDIR holds documentation.

Please check these issues and resubmit if appropriate.

You are receiving this mail because:
You are the assignee for the bug.