[Bug 274595] net-p2p/monero-cli: new build option added

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 19 Oct 2023 17:25:47 UTC 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274595

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
           Assignee|ports-bugs@FreeBSD.org      |fuz@FreeBSD.org

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for catching that.  As per ยง 13.14.4 Porter's Handbook, -march=native
must not be enabled by default.

Your patch is good, but please rename the option to NATIVE (this is the
standard name in ports for such an option, you can omit NATIVE_DESC as it is
provided in bsd.options.desc.mk) and make it enable -march=native with the flag
being off by default.

I think it might be possible to avoid the patch to CMakeLists.txt by using

    NATIVE_CMAKE_ON= -DARCH=native
    NATIVE_CMAKE_OFF= -DARCH=default

but I'm not super familiar with cmake, so please check for yourself.

Also please increment PORTREVISION by only 1 for each update.

-- 
You are receiving this mail because:
You are the assignee for the bug.