From nobody Sun Oct 15 21:38:44 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S7tsf62qXz4xR9f for ; Sun, 15 Oct 2023 21:38:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S7tsf51KVz3GW3 for ; Sun, 15 Oct 2023 21:38:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697405926; a=rsa-sha256; cv=none; b=jvIgQtMvViur0uOovEmJfsXQMPCFuzwdZk001JDqXjRIanq+UPV/5ZKtju9ZrB+Xc/zBRP xEGTy7FBLaXmUg4cqm5fdabGmYsI30MmI1VpK1A+uelDw29osV1xO/PmjBVr8bQE6nbRqc tzifC4qitU4V9YpTzfj6yZPUcpIfEEkVvq+r2p+ypLFk3KW8BufpIlVvErLWX6FLBhhVge +Ww8syByiLSlbO4uSdOjoxIkZpC04l0p3kW1gnKLskQEp+QEOxj0FIG3XEkqdLbgA6aWhX nLClHv9ZeytJxG+Bjqs1gNMBh3ty99iN23ZZx/iF0moS/rDnYj+nDAo38z+zWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697405926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QzydCdpPpLSiqb4wE6SH3oCTFeoIgWzHcTbh9Nvrpgo=; b=JrrwoAcog1EKAIgeT0uck7s+ErHjJ2lXLEEBB59L3sf4NuvAqK9JYpyrbvmx4s/ZZU7LLB 2sz7wT6htXj04tOn0FLqlR/5FJbLSMTKdV6N2lsAjGzbQ6OM7LPwmwkBJPR7Ww3FcqB6nc h5uBz48IPfe0vYdHpm5gCzmg2zctAJvL/VrJCu/3B6JD6PSPP7hRz9tBVsymUKrqAAF42E 1CX/ToDlRXDzIYiNUTd588+mRDYYt26du/tK2CMM3KVCRnBk41L5RvFzk90Y2OoBYvgAR7 i0SdmXGEmD18g/EDsW5JDMdXfKzbyBrhwTV6wq5msIbFv+hMjql9hEL32MYxdg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S7tsf43Mcz23 for ; Sun, 15 Oct 2023 21:38:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39FLckTY076324 for ; Sun, 15 Oct 2023 21:38:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39FLckI9076323 for ports-bugs@FreeBSD.org; Sun, 15 Oct 2023 21:38:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 270383] net/samba417: Add new port Date: Sun, 15 Oct 2023 21:38:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: freebsd@kumba.dev X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270383 --- Comment #4 from Joshua Kinard --- I've taken a stab at updating the samba416 port into a samba419 port, and c= an report success, so an extent. I iterated through both samba417 and samba418 ports in the process. The samba417 port work is based on that which is alr= eady posted to this bug. I am uploading all patches involved, just in case anyo= ne wants to try the different versions. There is also a direct patch that goes from net/samba416 to net/samba419 as well. Of note, three of the ports that are dependencies for Samba also require updating. I will attach patches for those here as well, but I can also cre= ate new bugs for each of them and link them as blockers, if that would be better from a bug management standpoint. It also looks like FreeBSD relies on the bundled 'ldb' library within Samba, rather than using one of the versioned instances in ports. I assume this is because ldb and Samba tend to be lock= ed to specific versions, and this can create dependency nightmares (which I ha= ve had encounters with on the Linux-side of things before, so I am no stranger there). The three dependencies that need to be bumped are: databases/tdb 1.4.7 --> 1.4.9 devel/talloc 2.3.4 --> 2.4.1 devel/tevent 0.13.0 --> 0.15.0 All of my testing/experimentation has been only on the file server elements= of Samba. I have no tested anything more advanced, like domain controller functionality, kerberos bits, etc. I don't run those services on my networ= k, so don't have a need to mess with them. Additional eyes and scrutiny is go= ing to be needed on those areas to make sure nothing breaking is missed before adding this all to Ports. The change from 4.16.x to 4.17.x is fairly uneventful and are already documented in this bug. Things got more interesting when going from 4.17.x to 4.18.x... Back in net/samba416, when that was added, it included a patch, files/0099-s3-modules-zfsacl-fix-get-set-ACL-on-FreeBSD-13.patch, which add= ed some O_PATH logic to the `fget_zfsacl` function, which included calling the `get_zfsacl` function. In mid-summer 2022, the `get_zfsacl` function was removed in commit 09a844c69ebf, and while this won't immediately cause a bu= ild error, when you go to connect to a Samba instance built this way, the connection will fail because the dynamic loader is unable to locate the sym= bol for `get_zfsacl`. A quick and dirty fix for this is to add that function back in by reversing= the commit that removed it. I suspect this is not a viable long-term fix and t= hat the O_PATH logic needs to be fixed to deal with this function's removal, bu= t I wasn't able to locate any information about that O_PATH patch, so I leave t= hat to those who better understand the code. For now, the patch to go from 4.1= 7.x to 4.18.x reverses the upstream commit and adds `get_zfsacl` back in, and t= hus, we get a working net/samba418 port. Additionally, the patch files/0028-s3-lib-system-add-FreeBSD-proc_fd_pattern.patch, is removed due = to being in upstream now. Going from 4.18.x to 4.19.x is less complicated. The patch, files/0100-From-872ea49ac6dced44f114f80b7065017a381f46d7.patch, added by the net/samba417 update, is dropped, as it's merged into the upstream source no= w, and a few additional pkg-plist entries were added for a new log-parser bina= ry and removing an old man page. The end result is a net/samba419 port updated to samba-4.19.1, the latest release (as of writing), and it's been running on my home NAS system for several days now with no noticeable impacts, and no glaring issues in the logging. One configuration directive is dropped, "directory name cache siz= e", but this doesn't impact the running of the server process. So I think the primary fix here is handling the removal of `get_zfsacl` from the upstream code in the added O_PATH logic. If better minds have ideas for that, I am willing to test. PS, can this bug be assigned to the samba port maintainer? --=20 You are receiving this mail because: You are the assignee for the bug.=