[Bug 274433] ports-mgmt/poudriere: broken option logic after introducing portconfig
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 12 Oct 2023 15:38:59 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274433
Bug ID: 274433
Summary: ports-mgmt/poudriere: broken option logic after
introducing portconfig
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Severity: Affects Some People
Priority: ---
Component: Individual Port(s)
Assignee: bdrewery@FreeBSD.org
Reporter: vsasjason@gmail.com
CC: bapt@FreeBSD.org, madpilot@FreeBSD.org
Flags: maintainer-feedback?(bdrewery@FreeBSD.org)
Assignee: bdrewery@FreeBSD.org
0cae7336b7c9fcfceac895ee6b9104e01d6a04d1 and next 5 commits introduced some
mess in options and this is not fixed at the moment of creating this PR:
* PORTCONFIG option says "install _dialog4ports_ ..." in its description;
* Actual support for dialog4ports is removed in port options, but still
available in files/patch-portconfig. According to that patch, it was meant to
_add_ portconfig support, not _replace_ dialog4ports with it (or the patch is
incorrect).
I believe following is the right way:
* restore original DIALOG4PORTS option
* add PORTCONFIG option and set correct description
* make both options grouped (according to code, RADIO isn't required as
multiselect will work)
* set whatever option as default, but allow those who used DIALOG4PORTS to
continue that
--
You are receiving this mail because:
You are the assignee for the bug.