[Bug 262032] [NEW PORT] devel/xnvme: Cross-platform libraries and tools for NVMe devices

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 09 Oct 2023 11:53:16 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262032

Karl Bonde Torp <k.torp@samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245464|0                           |1
        is obsolete|                            |
 Attachment #245527|                            |maintainer-approval+
              Flags|                            |

--- Comment #7 from Karl Bonde Torp <k.torp@samsung.com> ---
Created attachment 245527
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=245527&action=edit
devel/xnvme: Cross-platform libraries and tools for NVMe devices

I have attempted to address everything, however some things will come later.
Specifically, the warning you see on arm64 has already been fixed upstream
after 0.7.1 has been released.

I am unsure what to do about completions, currently we only have Bash
completions.
Meson setup checks if bash is available on the system, to make sure that we
install them in a sensible place.
Perhaps we should change this to always install them here
`${PREFIX}/share/bash-completion/completions` on FreeBSD.
Do we need completions for Fish and ZSH as well?

Finally, I have added options for the Tools, tests, examples etc., however this
makes the pkg-plist inaccurate, since it only reflects the default.
Is this okay, or is there something I need to do to fix this?

-- 
You are receiving this mail because:
You are the assignee for the bug.