[Bug 262032] [NEW PORT] devel/xnvme: Cross-platform libraries and tools for NVMe devices

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262032

--- Comment #5 from Robert Clausecker <fuz@FreeBSD.org> ---
Other things you should check:

 - general policy is to install all shell completion files, even if the
   corresponding shells are not installed.  Do not add dependencies on the
   shells you install completion files for.  See § 6.33 Porter's Handbook
   for details.  Shell completion files can be made optional, but that's only
   really needed if they are of substantial size.
 - add an option TEST and only install test binaries if this option is set.
   It seems like these binaries are not required for normal use, but feel
   free to correct me if I am wrong.
 - same thing applies to examples (with option EXAMPLES)
 - if you expect the library to be used separately from the tools, it might
   make sense to split the port into one port that only installs libraries and
   one that only installs tools and depends on the library port.
 - the port needs to set USE_LDCONFIG=yes as it installs shared libraries.
 - you may want to create a separate port for the Python bindings if desired
 - I see that you have extensive additional documentation.  It would be great
   if you could add a DOCS option and install that documentation if it is
   enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.