[Bug 275261] net/netatalk3 fails to build on 14.0-RELEASE

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275261

            Bug ID: 275261
           Summary: net/netatalk3 fails to build on 14.0-RELEASE
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus@FreeBSD.org
          Reporter: girgen@FreeBSD.org
             Flags: maintainer-feedback?(marcus@FreeBSD.org)
          Assignee: marcus@FreeBSD.org

Running poudriere on 14.0-RELEASE (both build jail and host).

netatalk fails to build nagging about "incompatible function pointer types
initializing 'int (*)(int, const struct pam_message **, struct pam_response **,
void *)' with an expression of type 'int (*)(int, struct pam_message **, struct
pam_response **, void *)'".

It seems that clang is more picky about const struct vs struct:

libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../.. -I../../include
-I../../include -I../.. -DLIBICONV_PLUG -I/usr/include/openssl
-I/usr/local/include "-D_U_=__attribute__((unused))" -O2 -pipe
-I/usr/local/include -L/usr/local/lib -DLIBICONV_PLUG -fstack-protector-strong
-fno-strict-aliasing -MT uams_passwd.lo -MD -MP -MF .deps/uams_passwd.Tpo -c
uams_passwd.c -o uams_passwd.o >/dev/null 2>&1
/bin/sh ../../libtool  --tag=CC   --mode=link cc -I/usr/include/openssl
-I/usr/local/include -D_U_="__attribute__((unused))" -O2 -pipe 
-I/usr/local/include -L/usr/local/lib -DLIBICONV_PLUG -fstack-protector-strong
-fno-strict-aliasing  -module -avoid-version -lcrypt  -fstack-protector-strong 
-o uams_passwd.la -rpath /usr/local/libexec/netatalk-uams uams_passwd.lo  
libtool: link: cc -shared  -fPIC -DPIC  .libs/uams_passwd.o   -L/usr/local/lib
-lcrypt  -O2 -fstack-protector-strong -fstack-protector-strong   -Wl,-soname
-Wl,uams_passwd.so -o .libs/uams_passwd.so
libtool: link: ar cr .libs/uams_passwd.a  uams_passwd.o
libtool: link: ranlib .libs/uams_passwd.a
libtool: link: ( cd ".libs" && rm -f "uams_passwd.la" && ln -s
"../uams_passwd.la" "uams_passwd.la" )
/bin/sh ../../libtool  --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I../..
  -I../../include -I../../include -I../.. -DLIBICONV_PLUG 
-D_U_="__attribute__((unused))" -O2 -pipe  -I/usr/local/include
-L/usr/local/lib -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing 
-MT uams_pam_la-uams_pam.lo -MD -MP -MF .deps/uams_pam_la-uams_pam.Tpo -c -o
uams_pam_la-uams_pam.lo `test -f 'uams_pam.c' || echo './'`uams_pam.c
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../.. -I../../include
-I../../include -I../.. -DLIBICONV_PLUG "-D_U_=__attribute__((unused))" -O2
-pipe -I/usr/local/include -L/usr/local/lib -DLIBICONV_PLUG
-fstack-protector-strong -fno-strict-aliasing -MT uams_pam_la-uams_pam.lo -MD
-MP -MF .deps/uams_pam_la-uams_pam.Tpo -c uams_pam.c  -fPIC -DPIC -o
.libs/uams_pam_la-uams_pam.o
cc: warning: argument unused during compilation: '-L/usr/local/lib'
[-Wunused-command-line-argument]
uams_pam.c:127:3: error: incompatible function pointer types initializing 'int
(*)(int, const struct pam_message **, struct pam_response **, void *)' with an
expression of type 'int (*)(int, struct pam_message **, struct pam_response **,
void *)' [-Wincompatible-function-pointer-types]
  &PAM_conv,
  ^~~~~~~~~
1 error generated.
gmake[4]: *** [Makefile:795: uams_pam_la-uams_pam.lo] Error 1
gmake[4]: Leaving directory
'/wrkdirs/usr/ports/net/netatalk3/work/netatalk-3.1.18/etc/uams'
gmake[3]: *** [Makefile:476: all-recursive] Error 1
gmake[3]: Leaving directory
'/wrkdirs/usr/ports/net/netatalk3/work/netatalk-3.1.18/etc'
gmake[2]: *** [Makefile:533: all-recursive] Error 1
gmake[2]: Leaving directory
'/wrkdirs/usr/ports/net/netatalk3/work/netatalk-3.1.18'
gmake[1]: *** [Makefile:465: all] Error 2
gmake[1]: Leaving directory
'/wrkdirs/usr/ports/net/netatalk3/work/netatalk-3.1.18'
*** Error code 1

Stop.
make: stopped in /usr/ports/net/netatalk3
=>> Cleaning up wrkdir
===>  Cleaning for netatalk3-3.1.18,1
build of net/netatalk3 | netatalk3-3.1.18,1 ended at Wed Nov 22 15:32:31 CET
2023
build time: 00:01:04
!!! build failure encountered !!!

-- 
You are receiving this mail because:
You are the assignee for the bug.