[Bug 275039] dns/void-zones-tools: not WITH_PIE safe

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 18 Nov 2023 07:06:05 UTC 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275039

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #3 from Robert Clausecker <fuz@FreeBSD.org> ---
This patch doesn't look right as it now unconditionally adds -fpic, even if we
create a position-dependent binary.

I don't get why you had -fno-pic in there in the first place.  If you just
remove that flag, I suspect it'll just work as expected.

Failing that, please change the port so -fpic is only passed if WITH_PIE is
set.  E.g. you can do 

    CFLAGS+= ${WITH_PIE:D-fpic}

in the port Makefile.

-- 
You are receiving this mail because:
You are the assignee for the bug.