[Bug 274847] www/node18: Remove DTrace support to fix build with upcoming binutils 2.41

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 01 Nov 2023 09:54:31 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274847

            Bug ID: 274847
           Summary: www/node18: Remove DTrace support to fix build with
                    upcoming binutils 2.41
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: sunpoet@FreeBSD.org
          Reporter: yasu@freebsd.org
            Blocks: 272853
          Assignee: sunpoet@FreeBSD.org
             Flags: maintainer-feedback?(sunpoet@FreeBSD.org)

Created attachment 246046
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=246046&action=edit
Patch file

* With binutils 2.41 build fails as following.
     
LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/lib.host:/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/lib.target:$LD_LIBRARY_PATH;
export LD_LIBRARY_PATH; cd ../.; mkdir -p
/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj.target/libnode/src;
dtrace -64
"-I/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj/gen" -Isrc
-C -G -s src/v8ustack.d -o
"/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj.target/libnode/src/node_dtrace_ustack.o"
    dtrace: failed to compile script src/v8ustack.d: line 1: failed to resolve
V8DBG_SMITAG: Unknown variable name
* This is because behaviour of objdump has changes with binutils 2.41. [1][2]
* On upstream DTrace support itself has been removed with Node.js 19.x.
* There is a pull request that says it fixes build error. [3]  I tried it but
unfortunately it doesn't work as is expected.
* Upstream suggests me to remove DTrace support. [4]

Reference:      https://github.com/nodejs/node/issues/49991#issue-1920717730
[1]
Reference:     
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8 [2]
Reference:      https://github.com/nodejs/node/pull/49992 [3]
Reference:     
https://github.com/nodejs/node/pull/49992#issuecomment-1784231190 [4]


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272853
[Bug 272853] devel/binutils: Update to 2.41
-- 
You are receiving this mail because:
You are the assignee for the bug.