From nobody Sat May 27 09:26:39 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QSxHz5ym2z4Wmrt for ; Sat, 27 May 2023 09:26:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QSxHz4z4mz3jtl for ; Sat, 27 May 2023 09:26:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685179599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9srlgT7R+lvKZq6WEVYuKo8q9ZvVfo426/wq2F4/2AU=; b=mi/wRg9IcnUL6ZmL3vuuXltTN0Y1Bo3Ci2kqh3UfUV7y+lKrfxubcqiuIP1EoCALx7fqC4 K/edAIc145BaChnA3RAixBaJlqLEVbc3kHWop8+v22f2oHV/viecLk8OSyQJC8LDtIvTGL y1e+xjdbWbVP6p7Zcug3ntting9drdnHIeVKLK0mglDDTr9Jbv+jsRpuUTM6dzg2rzxA7n gbt1pJPZzCiE5aW1u/Pn0tazhZPwFebB7lfgtdX0bf/9skQOMO76ePHAUAtdD+WnY5+rAH bphaU2+46xNgWMv+pIkLkV4auQRPMd6InpP9AadzIMycFvmDyte6vvtjvXO6+A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685179599; a=rsa-sha256; cv=none; b=enJmVYec80UPE+pYVF+HUp3L74kPRXYRhqrZ8VV8WeuxYTWOXG1Dat4vuUzM2hQBOVCS3M 0r16rVH9zrNvk71juaKLJs5TVVSNS/NFYYtva7JGW+4VPUmJ42qw2fbDd5nwDfOf+gscrW 1Ow6JrGdUcuzxjN+so2R+G8hR5Jbb6VmKxBckKEQaOC1tjwSKQjDX4+kx8BxZANXiRrmjb q87TiZTCy+bSQnYhrMDXsIZOs6fclPLQM9PPyVAjB03vZIQSbjulM0Vq+vaDxlnwcJ2t8J zzdxdqNlwax3LUb0ooacXryom/SZT1EUB0AVa90uwcZx/NukimVofVI0Rg6Tkw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QSxHz3wMvzjrj for ; Sat, 27 May 2023 09:26:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34R9QdDA017364 for ; Sat, 27 May 2023 09:26:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34R9QdOC017363 for ports-bugs@FreeBSD.org; Sat, 27 May 2023 09:26:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 271374] emulators/mame-0.254 fails to build on {arm64,amd64,i386}-14-CURRENT Date: Sat, 27 May 2023 09:26:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: agh@riseup.net X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271374 --- Comment #27 from Alastair Hogge --- (In reply to Robert Clausecker from comment #26) > Looks cool! Here are some things I found: > > - do-install-DEBUG-on and do-install-DEBUG-off do the same thing and can= be merged; just put the commands into do-install Are you sure? I am not. MAME builds "mamed" with DEBUG, and "mame" without DEBUG. Do you think we should just install with the d suffix? > - I recommend that you keep the mention of armv7 in the comment above LD= FLAGS. > Else a future maintainer might test on amd64 and find that it is not n= eeded, > breaking the port once more (you won't believe how often that happens). Ohh good point. Will add/restore. Thanks. > - the conditionals for the QTDEBUGGER option are commented out. Yeah, the patch is still WIP (Work In Progress), and I was lazy and left so= me crumbs lying around, my bad. > Is this correct? You can rewrite them like such: > > QTDEBUGGER_MAKE_ENV=3D USE_QTDEBUG=3D1 > QTDEBUGGER_USES=3D qt:5 > QTDEBUGGER_USE=3D qt=3Dcore,gui,widgets,buildtools:build,qmake:build Oh that is that far more elegant, totally happening, thanks. > - in OVERRIDE_CC for FreeBSD > 14, you should not use COMPILER_TYPE as i= t could > be gcc. Just write e.g. clang++${LLVM_VERSION}. Ah yes, thanks, again more crumbs. > - check if you can use DISTVERSION instead of PORTVERSION as per policy Good idea, will do. > - would it make sense to make TOOLS=3D1 a port option so people can get = a leaner mame if they want? Farken oath I think it would (I think it is only 3 more binaries), great id= ea, totally happening. Thanks. --=20 You are receiving this mail because: You are the assignee for the bug.=