[Bug 271623] ports-mgmt/portlint: False positive on desktop-file-utils

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 25 May 2023 03:47:40 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271623

            Bug ID: 271623
           Summary: ports-mgmt/portlint: False positive on
                    desktop-file-utils
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus@FreeBSD.org
          Reporter: lcook@freebsd.org
             Flags: maintainer-feedback?(marcus@FreeBSD.org)
          Assignee: marcus@FreeBSD.org

When working on some ports earlier, after some sanity checking, I came across a
false positive regarding the usage of desktop-file-utils. The confusing part
was on the one hand portlint(1) complaining about the absence of
`USES=desktop-file-utils`, while the other in the stage-qa target told me that
it was unnecessary after the fact of adding it.

The culprit in portlint(1) appears to be here[0]. Just the presence of an
`.desktop` file trips the check up without determining whether a MimeType is
actually specified (seen in Scripts/qa.sh[1]; we should follow this behaviour
as currently this is an incorrect assumption of portlint(1) and a little
confusing to consumers).

Unfortunately my perl-foo is quite rusty, ergo this problem report. :)  

[0]
https://cgit.freebsd.org/ports/tree/ports-mgmt/portlint/src/portlint.pl#n813
[1] https://cgit.freebsd.org/ports/tree/Mk/Scripts/qa.sh#n222

-- 
You are receiving this mail because:
You are the assignee for the bug.