[Bug 269566] New port: lang/mlkit

In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 269566] New port: lang/mlkit"
Go to: [ bottom of page ] [ top of archives ] [ this month ]
From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 22 May 2023 18:49:26 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269566

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ports-bugs@FreeBSD.org      |fuz@FreeBSD.org

--- Comment #14 from Robert Clausecker <fuz@FreeBSD.org> ---
Looks good!

But oh boy, that thing wants 20 GB of RAM to compile.  Not sure if our ports
build cluster is configured to have that much per jail.  Is it possible to make
it use less RAM?

I've also noticed that there are orphaned files.  You can check for thesewith
"make check-plist".  One workaround is to remove these in post-install:

lang/mlkit$ make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/mlkit/basis/ARRAY.sig.log
Error: Orphaned: lib/mlkit/basis/ARRAY2.sig.log
Error: Orphaned: lib/mlkit/basis/ARRAY_SLICE.sml.log
Error: Orphaned: lib/mlkit/basis/Array.sml.log
Error: Orphaned: lib/mlkit/basis/Array2.sml.log
Error: Orphaned: lib/mlkit/basis/ArraySlice.sml.log
Error: Orphaned: lib/mlkit/basis/BIT_FLAGS.sml.log
Error: Orphaned: lib/mlkit/basis/BOOL.sig.log
Error: Orphaned: lib/mlkit/basis/BYTE.sig.log
Error: Orphaned: lib/mlkit/basis/BitFlags.sml.log
Error: Orphaned: lib/mlkit/basis/Bool.sml.log
Error: Orphaned: lib/mlkit/basis/Byte.sml.log
Error: Orphaned: lib/mlkit/basis/ByteSlice.sml.log
Error: Orphaned: lib/mlkit/basis/ByteTable.sml.log
Error: Orphaned: lib/mlkit/basis/CHAR.sig.log
Error: Orphaned: lib/mlkit/basis/COMMAND_LINE.sml.log
Error: Orphaned: lib/mlkit/basis/Char.sml.log
Error: Orphaned: lib/mlkit/basis/CommandLine.sml.log
Error: Orphaned: lib/mlkit/basis/DATE.sig.log
Error: Orphaned: lib/mlkit/basis/Date.sml.log
Error: Orphaned: lib/mlkit/basis/FileSys.sml.log
Error: Orphaned: lib/mlkit/basis/GENERAL.sig.log
Error: Orphaned: lib/mlkit/basis/General.sml.log
Error: Orphaned: lib/mlkit/basis/INET_SOCK.sig.log
Error: Orphaned: lib/mlkit/basis/INTEGER.sml.log
Error: Orphaned: lib/mlkit/basis/INT_INF.sml.log
Error: Orphaned: lib/mlkit/basis/INT_INF_REP.sml.log
Error: Orphaned: lib/mlkit/basis/IO.sml.log
Error: Orphaned: lib/mlkit/basis/Initial.sml.log
Error: Orphaned: lib/mlkit/basis/Initial2.sml.log
Error: Orphaned: lib/mlkit/basis/Int.sml.log
Error: Orphaned: lib/mlkit/basis/Int31.sml.log
Error: Orphaned: lib/mlkit/basis/Int32.sml.log
Error: Orphaned: lib/mlkit/basis/Int63.sml.log
Error: Orphaned: lib/mlkit/basis/Int64.sml.log
Error: Orphaned: lib/mlkit/basis/IntInf.sml.log
Error: Orphaned: lib/mlkit/basis/IntInfRep.sml.log
Error: Orphaned: lib/mlkit/basis/LIST.sig.log
Error: Orphaned: lib/mlkit/basis/LIST_PAIR.sml.log
Error: Orphaned: lib/mlkit/basis/List.sml.log
Error: Orphaned: lib/mlkit/basis/ListPair.sml.log
Error: Orphaned: lib/mlkit/basis/MATH.sig.log
Error: Orphaned: lib/mlkit/basis/MONO_ARRAY.sml.log
Error: Orphaned: lib/mlkit/basis/MONO_ARRAY2.sml.log
Error: Orphaned: lib/mlkit/basis/MONO_ARRAY_SLICE.sml.log
Error: Orphaned: lib/mlkit/basis/MONO_VECTOR.sml.log
Error: Orphaned: lib/mlkit/basis/MONO_VECTOR_SLICE.sml.log
Error: Orphaned: lib/mlkit/basis/Math.sml.log
Error: Orphaned: lib/mlkit/basis/NET_HOST_DB.sig.log
Error: Orphaned: lib/mlkit/basis/NetHostDB.sml.log
Error: Orphaned: lib/mlkit/basis/OPTION.sig.log
Error: Orphaned: lib/mlkit/basis/OS.sml.log
Error: Orphaned: lib/mlkit/basis/OSError.sml.log
Error: Orphaned: lib/mlkit/basis/OS_FILE_SYS.sml.log
Error: Orphaned: lib/mlkit/basis/OS_IO.sml.log
Error: Orphaned: lib/mlkit/basis/OS_PATH.sml.log
Error: Orphaned: lib/mlkit/basis/OS_PROCESS.sml.log
Error: Orphaned: lib/mlkit/basis/Option.sml.log
Error: Orphaned: lib/mlkit/basis/PACK_REAL.sml.log
Error: Orphaned: lib/mlkit/basis/PACK_WORD.sml.log
Error: Orphaned: lib/mlkit/basis/POSIX.sig.log
Error: Orphaned: lib/mlkit/basis/POSIX_ERROR.sml.log
Error: Orphaned: lib/mlkit/basis/POSIX_FILE_SYS.sml.log
Error: Orphaned: lib/mlkit/basis/POSIX_IO.sml.log
Error: Orphaned: lib/mlkit/basis/POSIX_PROCENV.sml.log
Error: Orphaned: lib/mlkit/basis/POSIX_PROCESS.sml.log
Error: Orphaned: lib/mlkit/basis/POSIX_SIGNAL.sml.log
Error: Orphaned: lib/mlkit/basis/POSIX_SYS_DB.sml.log
Error: Orphaned: lib/mlkit/basis/POSIX_TTY.sml.log
Error: Orphaned: lib/mlkit/basis/Pack32Big.sml.log
Error: Orphaned: lib/mlkit/basis/Pack32Little.sml.log
Error: Orphaned: lib/mlkit/basis/PackRealBig.sml.log
Error: Orphaned: lib/mlkit/basis/PackRealLittle.sml.log
Error: Orphaned: lib/mlkit/basis/Path.sml.log
Error: Orphaned: lib/mlkit/basis/Posix.sml.log
Error: Orphaned: lib/mlkit/basis/Process.sml.log
Error: Orphaned: lib/mlkit/basis/RANDOM.sig.log
Error: Orphaned: lib/mlkit/basis/REAL.sig.log
Error: Orphaned: lib/mlkit/basis/Random.sml.log
Error: Orphaned: lib/mlkit/basis/Real.sml.log
Error: Orphaned: lib/mlkit/basis/RealArray2.sml.log
Error: Orphaned: lib/mlkit/basis/RealArrayVector.sml.log
Error: Orphaned: lib/mlkit/basis/RealTable.sml.log
Error: Orphaned: lib/mlkit/basis/SOCKET.sig.log
Error: Orphaned: lib/mlkit/basis/STRING.sig.log
Error: Orphaned: lib/mlkit/basis/STRING_CVT.sml.log
Error: Orphaned: lib/mlkit/basis/STR_BASE.sml.log
Error: Orphaned: lib/mlkit/basis/SUBSTRING.sig.log
Error: Orphaned: lib/mlkit/basis/Socket.sml.log
Error: Orphaned: lib/mlkit/basis/StrBase.sml.log
Error: Orphaned: lib/mlkit/basis/String.sml.log
Error: Orphaned: lib/mlkit/basis/StringCvt.sml.log
Error: Orphaned: lib/mlkit/basis/Substring.sml.log
Error: Orphaned: lib/mlkit/basis/TEXT.sig.log
Error: Orphaned: lib/mlkit/basis/TIME.sig.log
Error: Orphaned: lib/mlkit/basis/TIMER.sig.log
Error: Orphaned: lib/mlkit/basis/TableSlice.sml.log
Error: Orphaned: lib/mlkit/basis/Text.sml.log
Error: Orphaned: lib/mlkit/basis/Time.sml.log
Error: Orphaned: lib/mlkit/basis/Timer.sml.log
Error: Orphaned: lib/mlkit/basis/UNIX.sig.log
Error: Orphaned: lib/mlkit/basis/Unix.sml.log
Error: Orphaned: lib/mlkit/basis/VECTOR.sig.log
Error: Orphaned: lib/mlkit/basis/VECTOR_SLICE.sml.log
Error: Orphaned: lib/mlkit/basis/Vector.sml.log
Error: Orphaned: lib/mlkit/basis/VectorSlice.sml.log
Error: Orphaned: lib/mlkit/basis/WORD.sig.log
Error: Orphaned: lib/mlkit/basis/Word.sml.log
Error: Orphaned: lib/mlkit/basis/Word16.sml.log
Error: Orphaned: lib/mlkit/basis/Word31.sml.log
Error: Orphaned: lib/mlkit/basis/Word32.sml.log
Error: Orphaned: lib/mlkit/basis/Word63.sml.log
Error: Orphaned: lib/mlkit/basis/Word64.sml.log
Error: Orphaned: lib/mlkit/basis/Word8.sml.log
Error: Orphaned: lib/mlkit/basis/WordN.sml.log
Error: Orphaned: lib/mlkit/basis/io/bin-io.sig.log
Error: Orphaned: lib/mlkit/basis/io/bin-io.sml.log
Error: Orphaned: lib/mlkit/basis/io/bin-prim-io.sml.log
Error: Orphaned: lib/mlkit/basis/io/bin-stream-io.sig.log
Error: Orphaned: lib/mlkit/basis/io/cleaner.sig.log
Error: Orphaned: lib/mlkit/basis/io/cleaner.sml.log
Error: Orphaned: lib/mlkit/basis/io/imperative-io.sig.log
Error: Orphaned: lib/mlkit/basis/io/imperative-io.sml.log
Error: Orphaned: lib/mlkit/basis/io/prim-io.sig.log
Error: Orphaned: lib/mlkit/basis/io/prim-io.sml.log
Error: Orphaned: lib/mlkit/basis/io/stream-io.sig.log
Error: Orphaned: lib/mlkit/basis/io/stream-io.sml.log
Error: Orphaned: lib/mlkit/basis/io/text-io.sig.log
Error: Orphaned: lib/mlkit/basis/io/text-io.sml.log
Error: Orphaned: lib/mlkit/basis/io/text-prim-io.sml.log
Error: Orphaned: lib/mlkit/basis/io/text-stream-io.sig.log
Error: Orphaned: lib/mlkit/basis/wordtables.sml.log
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/license/CODEMIRROR-LICENSE
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/license/GPL-LICENSE
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/license/MLKit-LICENSE
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/license/MLton-LICENSE
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/license/SMLNJ-LIB-LICENSE
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/license/SMLNJ-LICENSE

I can add on commit to fix this:

    post-install:
        ${FIND} ${STAGEDIR}${PREFIX}/lib/mlkit/basis -name \*.log -delete
        ${RM} -r ${STAGEDIR}${DOCSDIR}/license

Is that okay with you?

As for the test suite, it mostly passes, but there are some errors towards the
end:

gmake[2]: Entering directory
'/usr/home/main.ports/lang/mlkit/work/mlkit-4.7.3/test/explicit_regions'
../../bin/kittester "../../bin/mlkit -no_gc -no_basislib --maximum_inline_size
0 -er -no_opt" --logdirect all.tst
..
 ERR: compile log er1.sml.log not equal to er1.sml.log.ok
...
 ERR: compile log er2.sml.log not equal to er2.sml.log.ok
...
 ERR: compile log er3.sml.log not equal to er3.sml.log.ok
...
 ERR: compile log er4.sml.log not equal to er4.sml.log.ok
...
 ERR: compile log er5.sml.log not equal to er5.sml.log.ok
...
 ERR: compile log er6.sml.log not equal to er6.sml.log.ok
...
 ERR: compile log er7.sml.log not equal to er7.sml.log.ok
...
 ERR: compile log er8.sml.log not equal to er8.sml.log.ok
...
 ERR: compile log er9.sml.log not equal to er9.sml.log.ok
...
 ERR: compile log er10.sml.log not equal to er10.sml.log.ok
...
 ERR: compile log er11.sml.log not equal to er11.sml.log.ok
...
 ERR: compile log er12.sml.log not equal to er12.sml.log.ok
...
 ERR: compile log er13.sml.log not equal to er13.sml.log.ok
...
 ERR: compile log er14.sml.log not equal to er14.sml.log.ok
...
 ERR: compile log er15.sml.log not equal to er15.sml.log.ok
...
 ERR: compile log er16.sml.log not equal to er16.sml.log.ok
...
 ERR: compile log er17.sml.log not equal to er17.sml.log.ok
...
 ERR: unexpected compile time failure for param.sml
..
 ERR: unexpected compile time failure for param1.sml
..
 ERR: unexpected compile time failure for tup.sml
..
 ERR: unexpected compile time failure for tup2.sml
..
 ERR: unexpected compile time failure for rec.sml
..
 ERR: unexpected compile time failure for string.sml
..
 ERR: unexpected compile time failure for ref.sml
..
 ERR: unexpected compile time failure for con0.sml
..
 ERR: unexpected compile time failure for con1.sml
..
 ERR: unexpected compile time failure for call.sml
..
 ERR: unexpected compile time failure for call2.sml
 [28/28]
***TEST FAILED: there were 28 errors.

Please let me know if you would like for this to be committed as is or if you
want to fix this up first.

-- 
You are receiving this mail because:
You are the assignee for the bug.