[Bug 269566] New port: lang/mlkit

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 21 May 2023 14:06:12 UTC 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269566

--- Comment #10 from Robert Clausecker <fuz@FreeBSD.org> ---
(In reply to serpent7776 from comment #9)

> Maybe the TEST option should be removed altogether. The intent was to just run > tests provided by mlkit. I removed test related files from pkg-plist, because I > don't believe they are necessary to be in the package.

The correct way is to only add these files to the package if the TEST option is
set.  See ยง 8.1 Porter's Handbook for how to do that.  You can at the same time
hook up the test suite to the do-test target, but do it independently of the
TEST option.

> I'm not sure what to do about the canfigure.ac file. Should I just patch it to hardcode some values instead of querying git/date commands?

Yes, that works.  Bonus points if it includes PKGVERSION somewhere and that it
was built by FreeBSD ports and who the maintainer is and that sort of stuff. 
You can use REINPLACE_CMD for such dynamic replacements.

-- 
You are receiving this mail because:
You are the assignee for the bug.