[Bug 271400] print/py-fonttools: NO_ARCH is wrong if cython is used (and REPACKER is effectively on even if explicitly turned off)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271400

            Bug ID: 271400
           Summary: print/py-fonttools: NO_ARCH is wrong if cython is used
                    (and REPACKER is effectively on even if explicitly
                    turned off)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: sunpoet@FreeBSD.org
          Reporter: jcfyecrayz@liamekaens.com
          Assignee: sunpoet@FreeBSD.org
             Flags: maintainer-feedback?(sunpoet@FreeBSD.org)

If you build print/py-fonttools (currently at 4.93.3) with either of the
following two conditions...
 - REPACKER option on
 - or just the cython package installed (even if REPACKER is off)

... then 'make stage-qa' fails with this:

====> Running Q/A tests (stage-qa)
Warning: 'lib/python3.9/site-packages/fontTools/pens/momentsPen.cpython-39.so'
is not stripped consider trying INSTALL_TARGET=install-strip or using
${STRIP_CMD}
Warning: 'lib/python3.9/site-packages/fontTools/qu2cu/qu2cu.cpython-39.so' is
not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/python3.9/site-packages/fontTools/cu2qu/cu2qu.cpython-39.so' is
not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/python3.9/site-packages/fontTools/misc/bezierTools.cpython-39.so'
is not stripped consider trying INSTALL_TARGET=install-strip or using
${STRIP_CMD}
Warning: 'lib/python3.9/site-packages/fontTools/varLib/iup.cpython-39.so' is
not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/python3.9/site-packages/fontTools/feaLib/lexer.cpython-39.so' is
not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Error:
'/usr/local/lib/python3.9/site-packages/fontTools/cu2qu/cu2qu.cpython-39.so' is
a architecture specific binary file and you have set NO_ARCH.  Either remove
NO_ARCH or add 'cu2qu.cpython-39.so' to NO_ARCH_IGNORE.
Error:
'/usr/local/lib/python3.9/site-packages/fontTools/feaLib/lexer.cpython-39.so'
is a architecture specific binary file and you have set NO_ARCH.  Either remove
NO_ARCH or add 'lexer.cpython-39.so' to NO_ARCH_IGNORE.
Error:
'/usr/local/lib/python3.9/site-packages/fontTools/misc/bezierTools.cpython-39.so'
is a architecture specific binary file and you have set NO_ARCH.  Either remove
NO_ARCH or add 'bezierTools.cpython-39.so' to NO_ARCH_IGNORE.
Error:
'/usr/local/lib/python3.9/site-packages/fontTools/pens/momentsPen.cpython-39.so'
is a architecture specific binary file and you have set NO_ARCH.  Either remove
NO_ARCH or add 'momentsPen.cpython-39.so' to NO_ARCH_IGNORE.
Error:
'/usr/local/lib/python3.9/site-packages/fontTools/qu2cu/qu2cu.cpython-39.so' is
a architecture specific binary file and you have set NO_ARCH.  Either remove
NO_ARCH or add 'qu2cu.cpython-39.so' to NO_ARCH_IGNORE.
Error:
'/usr/local/lib/python3.9/site-packages/fontTools/varLib/iup.cpython-39.so' is
a architecture specific binary file and you have set NO_ARCH.  Either remove
NO_ARCH or add 'iup.cpython-39.so' to NO_ARCH_IGNORE.
*** Error code 1


There are two problems here:

 (1) The build should not be different just because cython is installed. 
Putting it another way, even if REPACKER is off, py-fonttools is built exactly
as if REPACKER is on when lang/cython is installed - that is, having
lang/cython installed effectively turns on the REPACKER option.

 (2) NO_ARCH=yes is no longer correct if .so files are being built and
packaged.


You would not notice this in a poudriere environment unless REPACKER is on
(it's off by default) - or if you do a bulk build that included both
lang/cython and print/py-fonttools.

-- 
You are receiving this mail because:
You are the assignee for the bug.