[Bug 269616] [NEW PORT] astro/osmium-tool: Command line tool for working with OpenStreetMap data based on the Osmium library

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269616

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org
             Status|New                         |Open

--- Comment #3 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  Please ensure to set maintainer-approval to +
on newly submitted ports so they get processed quicker.  Here are some things I
noticed:

 - your pkg-plist lists all the man pages, but these get only built when the
   MANPAGES option is on.  Either make the pkg-plist entries for man pages
   conditional on whether the option is set or not, or make installing man
pages
   unconditional.
 - please fix the indentation of the port Makefile.  You can use portfmt for
this.
 - it might be useful to enable the LZ4 option by default.  liblz4 is a really
   small library, so it doesn't hurt to have it.
 - your MANPAGES and LZ4 options do not set anything in the build scripts, so
   they will not work correctly when e.g. liblz4 is installed but not selected
   as an option.  Please check if you can wire the options through to the build
   system so LZ4 support is indeed only built if the option is set.

Port looks good otherwise!

-- 
You are receiving this mail because:
You are the assignee for the bug.