[Bug 270657] [NEW PORT] sysutils/plocate - locate that can find all files

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 03 May 2023 18:59:28 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270657

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org
             Status|New                         |Open

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  Please check the following issues:

 - please prefer DISTVERSION over PORTVERSION if possible
 - do not use REINPLACE_CMD for static replacements.  Instead, supply patch
   files.  Use the "make makepatch" mechanism to generate these (see ยง 4.4
   Porter's Handbook)
 - please use /var/db instead of ${PREFIX}/var/db for database files.
 - avoid not printing out shell commands in the Makefile
 - including a header file directly from FILESDIR is unconventional but ok.

Rest looks ok.  Will proceed with a build test once you address these issues.

Please make sure to set "maintainer-approval" on your patches so they are more
likely to be looked at.

-- 
You are receiving this mail because:
You are the assignee for the bug.