[Bug 269566] New port: lang/mlkit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269566

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org
             Status|New                         |Open

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your contribution!  Here are some issues I found:

Instead of adding the license file to PORTDOCS, set LICENSE_FILE=
${WRKSRC}/path/to/the/license.  If there are multiple licenses, each license
needs to be configured and its LICENSE_FILE set up.

Please set DISTVERSION instead of PORTVERSION unless DISTVERSION doesn't work
for you.

Why is the port "ONLY_FOR_ARCH=amd64"?  Please add ONLY_FOR_ARCH_REASON to
explain the reason for this restriction.  You having only tested the port for
this architecture is not sufficient reason to restrict it, you need to know
that it will not work on other architectures.

Please include bsd.port.option.mk only if your makefile needs to evaluate
option-specific macros.  This doesn't seem the case with your makefile.

Why did you set GH_TAGNAME to a git commit?  The USE_GITHUB mechanism is
capable of working with tag names.  You should simply set DISTVERSIONPREFIX= v
and leave out GH_TAGNAME.  This will do the right thing.

I also see that the Makefile is for the previous version.  Please check if you
can update it to the most recent version.

I also noticed that the variables are in the wrong order.  Please fix the order
in accordance with the Porter's Handbook.  The portclippy utility can help you
with that.

Are you sure CONFIGURE_SHELL is needed?  Are you sure DISABLE_MAKE_JOBS is
needed?

Each installed file must only be listed once.  Either in PORTDOCS/PLIST_FILES
or in the pkg-plist file.  Do not list files twice.

Check if you can make the demo and test files conditional on an option.  There
are standard option names TEST and EXAMPLES for these.

Please check these issues.  I can proceed with a build test once you have
addressed them.

-- 
You are receiving this mail because:
You are the assignee for the bug.