[Bug 269982] Mk/Scripts/depends-list.sh: Default flavour for dependencies are overriden

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269982

            Bug ID: 269982
           Summary: Mk/Scripts/depends-list.sh: Default flavour for
                    dependencies are overriden
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: janm@transactionware.com
                CC: x11@FreeBSD.org, xfce@FreeBSD.org
                CC: x11@FreeBSD.org, xfce@FreeBSD.org

Created attachment 240605
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=240605&action=edit
Patch solving the problem for me

When running "make all-depends-list", for some ports dependencies are not
listed. For example, "make all-depends-list" on x11-wm/xfce4 includes
x11-servers/xorg-server but not x11/libxcvt. For x11-servers/xorg-server, "make
all-depends-list" includes x11-libxcvt.

The underlying problem seems to be that Mk/Scripts/depends-list.sh sets FLAVOR,
even when it is an empty string. This breaks the default flavour setting in
x11-servers/xorg-server.

The bug is that that the flavour shell variable is not enclosed in quotes,
making the test for a non-empty string always succeed. Patch attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.