[Bug 267158] [NEW PORT] devel/arm-compute-library

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267158

--- Comment #12 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for the update.

What about the examples?  (see comment #5)

Is there a reason why they are only built on amd64?  The usual convention is to
have an option EXAMPLES conditionally on which examples are built.  I'm not
asking you to change this, just to explain your choice so I can understand the
port better.

I've also noticed that you have removed the ONLY_FOR_ARCHS bit.  If you do so,
please adapt the SCONS_ARGS bit with suitable default values for other
architectures.  E.g. you could do

SCONS_ARGS_amd64=       neon=0 opencl=1 examples=1 arch=x86_64
SCONS_ARGS_aarch64=     neon=1 opencl=0 examples=0 arch=arm64-v8a
SCONS_ARGS_armv7=       neon=1 opencl=0 examples=0 arch=armv7a
SCONS_ARGS_generic=     ...
SCONS_ARGS+=            os=freebsd Werror=0 embed_kernels=0 build=native
${SCONS_ARGS_${ARCH}:U${SCONS_ARGS_generic}}

I assume the bit about using the right CC and CXX is taken care of by
USES=scons?

Lastly, something that slipped by last time I reviewed your port: INSTALL_LIB
is for installing shared libraries only.  Use INSTALL_DATA for static libraries
(cf. § 5.17.1 Porter's Handbook).  This is because INSTALL_LIB possibly strips
the library, which is fatal for static libraries.

And instead of ${CP} -R, consider using COPYTREE_SHARE for installing the
include files.

I'll do a test run once my ports builder is free (currently processing some
other patches).

-- 
You are receiving this mail because:
You are the assignee for the bug.