[Bug 269381] Mk/Uses/magick.mk does not support OPTIONS_UNSET+= X11 in make.conf when package Makefile has "USES = magick"

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 03 Mar 2023 13:49:50 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269381

--- Comment #5 from fsbruva@yahoo.com ---
(In reply to lysfjord.daniel from comment #4)

My earlier claims of success about using imagemagick=7-nox11 only meant
poudriere constructed the correct dependencies. There is a syntax error in
Uses/magick.mk, because the build later fails with:

===>   vips-8.13.3_3 depends on shared library: libMagick++-7-nox11.so - not
found
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/vips

Once I started digging in magick.mk, I found some other logic errors. Right
now, if the user or ports tree specifies 6 or 7 as the default version, but a
port asks for -nox11, then magick.mk will (try to) install the -nox11 version.
There is no way for a user to mandate that the x11 version be installed as a
dependency via DEFAULT_VERSIONS. 

Additionally, there is no way for a port to mandate that the x11 version be
installed as a dependency. If the port omits the -nox11 flavor in USES because
it needs x11, but DEFAULT_VERSIONS specifies -nox11, then the port will have
unmet dependencies.

And your last point about ImageMagick itself correctly handling the X11 option
is a good one - I hadn't really thought of it that way. I will have to think
about how to try and make Uses/magick.mk check the UNSET options. I don't even
know if that's possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.