[Bug 271954] [NEW PORT] x11-wm/emwm Enhanced Motif Window Manager

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271954

--- Comment #4 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for the update.  This is a lot better.  Portlint still shows a few
warnings though, perhaps you can check them?  It seems like it is confused
because you swapped the MAINTAINER and LICENSE blocks.

A test build reveals that you use the PORTDOCS variable despite no DOCS
variable being defined.  Either put the README file into pkg-plist or add a
DOCS option (probably overkill).

A build test succeeds but there is this warning:

WmError.c:121:24: warning: incompatible function pointer types passing 'void
(char *)' to parameter of type 'void (*)(S
tring) __attribute__((noreturn))' (aka 'void (*)(char *)
__attribute__((noreturn))') [-Wincompatible-function-pointer-t
ypes]                                                                           
    XtSetErrorHandler (WmXtErrorHandler);                  
                       ^~~~~~~~~~~~~~~~                                         
/usr/local/include/X11/Intrinsic.h:1776:1: note: passing argument to parameter
here                                    
);                                                                              
^                                                                               
1 warning generated.

This warning is known to have become an error in LLVM16, which will be the
default on FreeBSD 14.  Check if you can add a patch for it.  To test with
LLVM16, install devel/llvm16 and build with

    make CC=clang16 CXX=clang++16

I noticed that the MAINTAINER email address in the port is different from the
one you use on bugzilla.  This may lead to problems as people will not
immediately see that you are the maintainer.  Also, we have hooks to
auto-notify the maintainer when a bug is files against one of his/her ports. 
Are you okay with me changing the MAINTAINER address in the patch to the same
you use on bugzilla?

-- 
You are receiving this mail because:
You are the assignee for the bug.