[Bug 271892] [NEW PORT] games/bitburner: incremental game with cyberpunk themes
Date: Sun, 25 Jun 2023 17:35:53 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271892
Robert Clausecker <fuz@FreeBSD.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fuz@FreeBSD.org
--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission. Here are some comments:
- make sure to set the "maintainer-approval" flag on patches so they get
looked at
- for auto-generated github distfiles, use USE_GITHUB as explained in
§ 5.4.3 Porter's Handbook. Do not use MASTER_SITES in this case.
Your port should just work if you remove MASTER_SITES and set
USE_GITHUB=yes.
- if a license file is included in the port, set LICENSE_FILE to its path
- instead of ${CP} and ${INSTALL}, use ${INSTALL_XXX} and ${COPYTREE_XXX} as
explained in § 5.17.1 and § 5.17.3 Porter's Handbook.
- the sample config file may fit better into EXAMPLESDIR. You do not need to
add an EXAMPLES option for a single file.
- check if you can set name and surname in your Bugzilla profile to ensure
that
your name is rendered correctly in our version control (not mandatory).
Will do a more thorough check once these issues have been addressed.
--
You are receiving this mail because:
You are the assignee for the bug.