From nobody Wed Jul 12 18:58:20 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R1RpN4kG2z2tjvP for ; Wed, 12 Jul 2023 18:58:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R1RpN2qBJz3Jcx for ; Wed, 12 Jul 2023 18:58:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689188300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nb/DeW0Uhl82e0KJe1uTYeWh0frPAulG6XGa0hCeh18=; b=D/v9byNF/A4LGIUSk6lfzJo/qST54OfyD/2PB0AS/no99YZRA83KfRlWFQTG85/+K4YLDM ufxAivwgseX9wqz9RXNpQjg77zdCmJuGkgDIrATgXtRwb1ePTiaxguPQyg9jwZeMUL2a9I lS4dEd6F9cOyFFGPCHmHNzZCzXeKEknVcBmLlivpe5F4mc5WAXw7lq5DCuiIkECzyERWzj 7oDzpt1NYbVJPaU0ooeYv5n2UlAX+gDwrXOjOfBLKDE9LUxw9gsd0s4W2VQUwX0267vgJf YDHEjFYSePP4eQO5r2ejwTr8dvPq97wiX2BMAxvwt8kgPIdQ054Qa6Ejt8HrlQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689188300; a=rsa-sha256; cv=none; b=DNUdUOx5ubAF8kNVwIzLzxOcJKv1sSnVGMwYtFVIITT0FZXSYuH7BiKVLEy+gzJEQg/hCm hga5FCpGcZHeRUvNzScr9d5iWd2ZgOv+xI0xBeO9AwfAyrEfsofUtKcz2V4VfKDU+oLWmx 9icHmaFORgRVtCPUVeOGqdxLjEOkJaUMSxRTpSMGat/33V1OnorC5TlmlDlj53gW740BPV s8mNyCBfM+DrLxuli46UilKnkAe0hlml4EfrbeftnOl28ZvyHAyywmyx6nAzlYCgBfAXWw 0q4KEUcxbQa0/xyA4gu06Rv/IVUJFcT3mK2Xqum+BSDdyCi3aEzyQ90SxuenKA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4R1RpN1wCLzL9f for ; Wed, 12 Jul 2023 18:58:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 36CIwKCV083325 for ; Wed, 12 Jul 2023 18:58:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 36CIwKNC083324 for ports-bugs@FreeBSD.org; Wed, 12 Jul 2023 18:58:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 248967] USE_GITLAB lacking support for tags Date: Wed, 12 Jul 2023 18:58:20 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248967 --- Comment #8 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D16bde072b16daca1c886116e602c94b= 5fa99c20f commit 16bde072b16daca1c886116e602c94b5fa99c20f Author: Felix Palmen AuthorDate: 2022-10-21 07:10:41 +0000 Commit: Felix Palmen CommitDate: 2023-07-12 18:55:08 +0000 bsd.sites.mk: Support tag names with USE_GITLAB Since quite some time, it's possible to download generated tarballs from gitlab for a tag name without knowing the corresponding git hash. This is preferable because you have a single source of truth about the software version. Support this by replacing GL_COMMIT with GL_TAGNAME which also accepts a commit hash, similar to USE_GITHUB. Unfortunately, there's a catch, the DISTFILE must be named exactly: ${GL_PROJECT}-${GL_TAGNAME}.tar.bz2, otherwise it extracts in a directory that contains the commit hash. So, we can't add the gitlab account or the revision suffix to make it work. Therefore, detect whether GL_TAGNAME contains a commit hash, and if it does, use the old behavior of deriving DISTNAME and DISTFILES. Document in CHANGES, also add a DEV_WARNING similar to USE_GITHUB when there's an URL in MASTER_SITES that looks like a gitlab URL. With support for tags, there shouldn't be any reason left to hardcode such an URL in MASTER_SITES. PR: 248967 Approved by: portmgr (tcberner, mentor) Differential Revision: https://reviews.freebsd.org/D37077 CHANGES | 16 ++++++++++++++ Mk/Uses/kde.mk | 2 +- Mk/Uses/xorg-cat.mk | 2 +- Mk/bsd.options.mk | 2 +- Mk/bsd.port.mk | 8 +------ Mk/bsd.sites.mk | 61 +++++++++++++++++++++++++++++++++++++------------= ---- 6 files changed, 63 insertions(+), 28 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=