[Bug 268776] audio/d11amp 0.61: New port 3

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268776

Felix Palmen <zirias@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zirias@freebsd.org
           Assignee|ports-bugs@FreeBSD.org      |zirias@freebsd.org
             Status|New                         |Open

--- Comment #1 from Felix Palmen <zirias@freebsd.org> ---
(In reply to Thomas Dettbarn from comment #0)

Thanks, this looks *almost* perfect.

A style nitpick: PLIST_FILES belongs *after* the "make block" (where you define
your TEST stuff).

And then, as your upstream *does* respect DESTDIR now, the whole do-install:
rule should be unnecessary. I will just test that now (will take a while again
as I have to rebuild lots of updated packages ...)

A little tip for upstream: you could make it even more flexible using a
structure e.g. like this:

---
PREFIX?=/usr/local
BINDIR?=$(PREFIX)/bin
MANDIR?=$(PREFIX)/share/man

INSTALLBIN=$(DESTDIR)$(BINDIR)
...
---

But it's of course fine as it is now for packaging purposes!

-- 
You are receiving this mail because:
You are the assignee for the bug.