[Bug 269443] sysutils/jdupes: Update to 1.21.3

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269443

--- Comment #10 from Fernando Apesteguía <fernape@FreeBSD.org> ---
(In reply to Thomas Hurst from comment #9)
I can reproduce it with your script. However, having a look at the compilation
output log from both poudriere and in host, the outputs are far from being
identical. For instance:

From your script (ie, 13.1 amd64 host):

cc -Wall -Wwrite-strings -Wcast-align -Wstrict-aliasing -Wstrict-prototypes
-Wpointer-arith -Wundef -Wshadow -Wfloat-equal -Waggregate-return -Wcast-qual
-Wswitch-default -Wswitch-enum -Wconversion -Wunreachable-code -Wformat=2
-std=gnu99 -O2 -g -D_FILE_OFFSET_BITS=64 -fstrict-aliasing -pipe
-DSMA_MAX_FREE=11 -DNO_ATIME -DNDEBUG -Wl,-z,stack-size=16777216    -c -o
jdupes.o jdupes.c

From poudriere jail for 13.1 amd64:

cc -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -Wall -Wwrite-strings -Wcast-align -Wstrict-aliasing
-Wstrict-prototypes -Wpointer-arith -Wundef -Wshadow -Wfloat-equal
-Waggregate-return -Wcast-qual -Wswitch-default -Wswitch-enum -Wconversion
-Wunreachable-code -Wformat=2 -std=gnu99 -D_FILE_OFFSET_BITS=64
-fstrict-aliasing -pipe -DSMA_MAX_FREE=11 -DNO_ATIME -Wextra
-Wstrict-overflow=5 -Winit-self -DNDEBUG -Wl,-z,stack-size=16777216  -isystem
/usr/local/include  -c -o jdupes.o jdupes.c

That's why I asked before if you might have any specific options in make.conf
or something.

So the output from poudriere has all the flags it has in the hosted compilation
except for "-g".

In addition, the ports framework adds the following:

-Wextra
-Winit-self
-Wstrict-overflow=5
-fno-strict-aliasing
-fstack-protector-strong
-isystem

One question would be, why would you want to strip an executable that has been
compiled with debug info (-g). At least in the porter's handbook we say "When
WITH_DEBUG is defined, elf files must not be stripped." Do you have WITH_DEBUG
in make.conf?

As a workaround, I think we could add a build dependency on devel/binutils and
then overwrite ${STRIP_CMD}.

-- 
You are receiving this mail because:
You are the assignee for the bug.