[Bug 274813] www/elog: Revive port

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274813

Erik Jensen <erik@tenku.dk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245995|0                           |1
        is obsolete|                            |
 Attachment #246912|                            |maintainer-approval+
              Flags|                            |

--- Comment #2 from Erik Jensen <erik@tenku.dk> ---
Created attachment 246912
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=246912&action=edit
Improved patch for revival of www/elog

Hi Robert,

I attach a new patch trying to accommodate your points - comments follow:

 - are the UID/GID values the same ones the port had before it was removed?
   If not, check if they can be made the same.
       ** I was unable to find this information anywhere in the latest, expired 
          commit @
https://svnweb.freebsd.org/ports/head/www/elog/?pathrev=366982.
          Is there anywhere else to look? I found this URL via freshports.
 - CC=c++ is our default setting, but is not correct to hard code.  Ports must
   obey whatever value CC is set to.  I recommend you change the Makefile patch
   to just remove any assignment to CC, CFLAGS, etc.  If you do that, the
   Makefile should grab the right values from the environment.  Failing that,
   you may be able to add CC=... to MAKE_ARGS.
      ** Should be fixed - turns out what is actually meant in the Makefile is
`CXX`, not `CC`.
 - why is the elog user needed?  I don't see any file owned by it nor an rc.d
   script or similar?  Please either remove the elog user/group or explain why
   it exists and how it is used.
      ** elog comes with a .service file for systemd and the like, but no rc.d
script.
         I added a file elogd.in to this new patch - please let me know if it
looks ok.
         The elog daemon assumes a user and a group by the names of "elog" when
it runs.
         This can be changed in the elog configuration, but it is not standard
for the service.
 - check if @sample should be used with the configuration file you install.
      ** I tried doing this - does it look ok?
 - move the installation steps for the documentation to target
do-install-DOCS-on
   so they are only run when DOCS is enabled
      ** Should be good.

Thanks,
Erik

-- 
You are receiving this mail because:
You are the assignee for the bug.