From nobody Sun Dec 03 16:35:35 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SjsqD4qjKz5353v for ; Sun, 3 Dec 2023 16:35:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SjsqD1b4kz3Fcn for ; Sun, 3 Dec 2023 16:35:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701621336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FAsiLzyWcXCFmACKQUK2wnAgJgwTLc713Gbj+fnW138=; b=iGLkEMty35inwiOXjp5Hwu7S3YyPl1x2mE04uySj80qFw12mgM7GZRHp9TqE6UBeL0c3he jZqTUwKbfdEz8EeqNX/H7xNO+uY38FcM4I55Kbi23nN/ysfLtfQW72/d+7l8GidQ8dsoOd W5p7J/WVFnnb4tm+B6WmeeJgEAq7Dt0l6AK9m1zNH7cmNxAVWzIp1MPqnVEglYpFwGqaZz GG/33xAriOD1kFVrgtfEo6fDOhmBCnjyE0KoBbNFbntsMxtB6yT/cP3MLZt7Ui/yjwjQZU GNGNfy1s5Fith5j45DQEPBv24VusjCdqleTf3TZila1zbmu5mlypzBQJb9CIWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701621336; a=rsa-sha256; cv=none; b=a3QY/oWCw8BAE/7nvbMxZbtBww9y0M62VcgV4a0538aFLc7vstBJUWBN8Fi1grNixp0FfK F1rKOhiHo/l9bkwfaAbeJ/uUuwQGjHEG8MLrXTfKcFSqJFLA2gwSDk7/pn8T4DOP+NtTbL tomvxWOFkDvV4rnvQvQU7kKP0h9Ql8B9lew4YNu/bQMypJJpLHeDWOS+LiWJ73m20lYlB7 I8o8NNDm+vi1jPvoDPG1W/ZSnQDvWpthzBdAUma2jYmX9T7WaYc3j3qxhWfuPLMbpzA4le n0CA3uQ1dwlP46zL+rGHC1OouJq4ZjtplNfbHbFNylOG5a5WaYw5akjXztRs/Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SjsqD0XtNz15pK for ; Sun, 3 Dec 2023 16:35:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3B3GZaCB086389 for ; Sun, 3 Dec 2023 16:35:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3B3GZaUj086388 for ports-bugs@FreeBSD.org; Sun, 3 Dec 2023 16:35:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 275508] sysutils/bsdisks: ensure uid_t is declared (else potential build error) Date: Sun, 03 Dec 2023 16:35:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jcfyecrayz@liamekaens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: arrowd@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275508 Bug ID: 275508 Summary: sysutils/bsdisks: ensure uid_t is declared (else potential build error) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: arrowd@FreeBSD.org Reporter: jcfyecrayz@liamekaens.com Flags: maintainer-feedback?(arrowd@FreeBSD.org) Assignee: arrowd@FreeBSD.org sysutils/bsdisks is failing to compile on 12.x blockfilesystem.h should include sys/types.h as it references uid_t. It's luck that it compiles on 13.x (due to the way system include files just happen to be written). POSIX states that uid_t is defined in sys/types.h Look for uid_t in these references: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/pwd.h.html As it turns out changes to sched.h resulted in getting uid_t defined for blockfilesystem.h on 13.x compile error: FAILED: CMakeFiles/bsdisks.dir/blockfilesystem.cpp.o /usr/bin/c++ -DINSTALL_PREFIX=3D\"/usr/local\" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_NO_DEBUG -I/usr/ports/sysutils/bsdisks/work/.build -I/usr/ports/sysutils/bsdisks/work/bsdisks-7472fc29bafb5cf44c539131d566fbe5= 41b7fd7d -I/usr/ports/sysutils/bsdisks/work/.build/bsdisks_autogen/include -isystem /usr/local/include/qt5 -isystem /usr/local/include/qt5/QtDBus -isystem /usr/local/include/qt5/QtCore -isystem /usr/local/lib/qt5/mkspecs/freebsd-c= lang -isystem /usr/local/include/polkit-qt5-1 -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -fstack-protector-strong -fno-strict-aliasin= g=20=20 -DNDEBUG -std=3Dgnu++17 -fPIC -pthread -MD -MT CMakeFiles/bsdisks.dir/blockfilesystem.cpp.o -MF CMakeFiles/bsdisks.dir/blockfilesystem.cpp.o.d -o CMakeFiles/bsdisks.dir/blockfilesystem.cpp.o -c /usr/ports/sysutils/bsdisks/work/bsdisks-7472fc29bafb5cf44c539131d566fbe541= b7fd7d/blockfilesystem.cpp In file included from /usr/ports/sysutils/bsdisks/work/bsdisks-7472fc29bafb5cf44c539131d566fbe541= b7fd7d/blockfilesystem.cpp:30: /usr/ports/sysutils/bsdisks/work/bsdisks-7472fc29bafb5cf44c539131d566fbe541= b7fd7d/blockfilesystem.h:54:29: error: use of undeclared identifier 'uid_t' QList> mountPoints; ^ /usr/ports/sysutils/bsdisks/work/bsdisks-7472fc29bafb5cf44c539131d566fbe541= b7fd7d/blockfilesystem.h:60:56: error: use of undeclared identifier 'uid_t' void unmountImplementation(QList>::iterator it, bool force, bool changed, std::shared_ptr context); ^ /usr/ports/sysutils/bsdisks/work/bsdisks-7472fc29bafb5cf44c539131d566fbe541= b7fd7d/blockfilesystem.cpp:218:23: error: out-of-line definition of 'unmountImplementation' does not match any declaration in 'BlockFilesystem' void BlockFilesystem::unmountImplementation(QList>::iterator it, bool force, bool changed, std::shared_ptr context) ^~~~~~~~~~~~~~~~~~~~~ /usr/ports/sysutils/bsdisks/work/bsdisks-7472fc29bafb5cf44c539131d566fbe541= b7fd7d/blockfilesystem.cpp:380:33: error: cannot initialize object parameter of type 'const QObject' with an expression of type 'BlockFilesystem' return qobject_cast(parent()); ^~~~~~ 4 errors generated. ninja: build stopped: subcommand failed. --=20 You are receiving this mail because: You are the assignee for the bug.=