[Bug 272312] [NEW PORT] security/p5-openxpki-clca: Toolkit for root CA

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272312

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org
             Status|New                         |Open

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  Contrary to what I said in my email, this
submission is not ready to be committed.

Some issues for you to check:

 - You seem to be doing a bunch of rote replacements in an unconventional way.
   Check if you can use USES=shebangfix instead
 - if not, I recommend writing a patch file that replaces all instances of the
   token you want to replace with some easy to see token.  Then use
REINPLACE_CMD
   to fix all instances of this token.  For example, replace openssl with
   %%OPENSSL%% in a patch file, then ${REINPLACE_CMD} -e
   s,%%OPENSSL%%,${something} to fix this up.  This simplifies the whole thing
to

       ${FIND} ${some_dir} -exec ${REINPLACE_CMD} -e ... {} +

 - I recommend moving ${REINPLACE_CMD} use to pre-configure as to not break
   make makepatch
 - in any way, do not delete the .bak files as these are used by stage-qa to
   check for misuse of REINPLACE_CMD
 - use ${PERL} instead of hardcoding ${PREFIX}/bin/perl
 - do not assume the port directory is writable.  Put temporarily files like
   filelist into ${WRKDIR}
 - your pkg-plist does not install anything unless EXAMPLES are selected.
   Is this correct?
 - do not define dummy do-build or do-install targets.  If you don't need these
   targets, define NO_BUILD=yes or NO_INSTALL=yes as appropriate.
 - your installation message recommends that the user copies all these files to
   his or her home directory.  Why is this needed?  Can't you install the
scripts
   and files into standard locations so they can be used from where they are?
   We want ports to be usable as they are.  Ports are not just a vehicle to
   download a bunch of files to the users computer.

-- 
You are receiving this mail because:
You are the assignee for the bug.