[Bug 272961] devel/msbuild: Avoid MSBuild error MSB1008

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 06 Aug 2023 00:18:44 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272961

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.
Would you be interested in taking up maintainership of this port?  It is quite
a bit out of date and could benefit from some attention.

As for your patch, please do not use REINPLACE_CMD for static replacements as
per Porter's Handbook.  I recommend having a patch file that adds something
like

    /m:%%MAKE_JOBS_NUMBER%%

and to then just have

    ${REINPLACE_CMD} -e s/%%MAKE_JOBS_NUMBER%%/${MAKE_JOBS_NUMBER}
${WRKSRC}/build/build.sh

I also recommend doing this dynamic replacement in pre-configure so it's easy
to run "make makepatch" after "make patch" (but not "make configure") to
regenerate the patches.

-- 
You are receiving this mail because:
You are the assignee for the bug.