[Bug 272193] [NEW PORT] multimedia/tstools: MPEG transport, program, and elementary stream tools

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 05 Aug 2023 13:38:29 UTC

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
             Status|New                         |Open
                 CC|                            |fuz@FreeBSD.org
           Assignee|ports-bugs@FreeBSD.org      |fuz@FreeBSD.org

--- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  This port looks good and can likely be
committed with some minor changes:

 - REINPLACE_CMD is only for dynamic replacements.  For static replacements,
   use patch files.
 - You seem to install a static library but no corresponding header files.  Is
   this really useful?  The Makefile's install rules do not seem to do so.
 - why is -fPIC needed?
 - man pages of section 1 should be installed into ${PREFIX}/share/man/man1.
   They should be installed unconditionally, no DOCS option needed.
   a post-install hook is present to automatically compress these, so install
   the .1 files but list .1.gz in pkg-plist.
 - is there any reason for not using the Makefile's install rules?

Please check and resubmit.

You are receiving this mail because:
You are the assignee for the bug.