[Bug 271128] net/freerdp: FTBFS after f7accb23b (ffmpeg update)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271128

Felix Palmen <zirias@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241851|0                           |1
        is obsolete|                            |

--- Comment #4 from Felix Palmen <zirias@freebsd.org> ---
Created attachment 241873
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=241873&action=edit
0001-net-freerdp-Fix-build-with-ffmpeg-6.v2

The patch wasn't enough for me. I found the "offender" was
channels/tsmf/client/ffmpeg/tsmf_ffmpeg.c which uses several deprecated ffmpeg
APIs that were finally removed in ffmpeg-6.

Attaching a patch now that also adds a local patch replacing these APIs (and I
just hope it is really correct...)

BUT: It seems this is drawn in by the GSTREAMER option if FFMPEG is enabled as
well. Upstream has no fixes, and I guess that's because this whole TSMF channel
is marked deprecated, see
https://github.com/FreeRDP/FreeRDP/commit/829497b313b2e8e5fc809c71466eb5a4db1a44dd

So maybe, a better way would be to never enable CHANNEL_TSMF in the port (not
sure whether it must be replaced with some other build option)?

-- 
You are receiving this mail because:
You are the assignee for the bug.