[Bug 258459] [new port] www/adjuster: Web Adjuster, Annotator Generator and TermLayout

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 29 Apr 2023 23:56:34 UTC

--- Comment #3 from Robert Clausecker <fuz@FreeBSD.org> ---
Here are some comments on your patch:

 - instead of manually fixing shebangs, check if you can use USES=shebangfix.
   It should automatically pick the right interpreter.
 - PYTHON_FLAVOR could be simplified to ${PYTHON_CMD:T} (though you won't need
   with USES=shebangfix)
 - instead of ${SED} -I '' use ${REINPLACE_CMD} (though you won't need it with
 - GH_PROJECT can be omitted if equal to PORTNAME
 - INSTALL_TARGET defaults to install and can be omitted.  If the port supports
   install-stripped, check if you can use that.
 - LICENSE_FILE should probably be ${WRKSRC}/LICENSE

Will commence with a build test once you fix these issues.

You are receiving this mail because:
You are the assignee for the bug.