[Bug 271139] lang/lua54: be aware of ABI break in new version 5.4.5

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271139

            Bug ID: 271139
           Summary: lang/lua54: be aware of ABI break in new version 5.4.5
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: andrew@tao11.riddles.org.uk
                CC: russ.haley@gmail.com
             Flags: maintainer-feedback?(russ.haley@gmail.com)
                CC: russ.haley@gmail.com

Putting this in here as a bug report even though the bug does not actually
exist yet in order to try and preempt any issues.

The just-released Lua 5.4.5 breaks the ABI by adding a new (pointer) parameter
to an existing function (lua_resetthread), so anything that calls this will
likely crash or misbehave if it was compiled against an older 5.4.x but finds
itself linked against a 5.4.5 version of liblua-5.4.so. Furthermore there is no
sane way for users of the library to protect against this, since no facility to
discover the exact library version is provided.

I have protested this change upstream, but I was too late; that was only about
half an hour before filing this, so I do not yet know what they will do.

I don't know what the best solution to this is. 5.4.5 fixes a lot of bugs, and
the ABI change is part of one of those fixes, but crashing is not a good
tradeoff. Perhaps the soname needs to change to include the minor version too,
but that's not a simple change and I don't know what other issues that would
cause.

Regardless, probably best not to just blindly update to 5.4.5 until this issue
has been properly considered.

-- 
You are receiving this mail because:
You are the assignee for the bug.