[Bug 254686] lang/scsh: Patch attached - undeleting and updating lang/scsh port

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254686

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
                 CC|                            |fuz@FreeBSD.org

--- Comment #4 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  Please make sure to set "maintainer-approval"
on your patch so it gets looked at.

 - please set MAINTAINER to your email address if you want to maintain this
port
 - your USE_GITHUB usage looks wonky.  Why is there no default distfile?
 - NO_STAGE is no longer supported.  Please remove it.
 - the way you deal with the SCRBL options seems very complicated.  I don't
   completely understand it.  Can it be done simpler?  For example, the
PORTDOCS
   loop could be simplified to

    .for opt in ${OPTIONS_GROUP_SCRBL}
    . if ${PORT_OPTIONS:M${.OPT.}}
    PORTDOCS+= ${${.OPT.}_DIR}/${SCRBL_FILES:.scribble=${${.OPT.}_EXT}}
    . endif
    .endfor

-- 
You are receiving this mail because:
You are the assignee for the bug.