[Bug 269419] graphics/mapnik: Re-add and fix build errors

In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 269419] graphics/mapnik: Re-add and fix build errors"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 27 Apr 2023 21:24:13 UTC

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269419

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
                 CC|                            |fuz@FreeBSD.org

--- Comment #6 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  Please make sure to set "maintainer-approval"
to have your patches looked at.

As for your patch:

 - please prefer DISTVERSION over PORTVERSION if possible
 - PORTDOCS=* should be avoided as it circumvents the point of having a pack
   list in the first place.  Unless it's very inconvenient, try to list all
   documentation explicitly.

Rest of the patch looks ok and can likely be committed once you fix these two
issues and set maintainer-approval.

-- 
You are receiving this mail because:
You are the assignee for the bug.