[Bug 270989] print/ghostscript10: adds libgs.so; connects to USES and DEFAULT_VERSIONS facilities; flavorized
Date: Mon, 24 Apr 2023 15:34:27 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270989 --- Comment #4 from Michael Osipov <michael.osipov@siemens.com> --- Went through most of the patch, although it mostly looks fine, the patch does way too much from my S/W dev PoV, seperate concerns need to be addressed separately: 1. Add dynamic linking 2. Flavorize port 3. Clean up ghostscript.mk, everything before 9 should be removed 4. Clean up ports not to use a specific version directly: > ./graphics/graphviz/Makefile:GHOSTSCRIPT_LIB_DEPENDS= libgs.so:print/${_GS_PORT} Uses an implementation detail which is not acceptable, should be "USES=ghostscript" > ./graphics/inkscape/Makefile: ps2pdf:print/ghostscript9-agpl-base \ "USES=ghostscript:run" > ./graphics/xfig/Makefile:LIB_DEPENDS= libgs.so:print/ghostscript9-agpl-base \ "USES=ghostscript" 5. Adapt patch on top of cleaned up ghostscript.mk to integrate flavors of 10 AND request an exp-run for 10 to see whether there are fallouts just to make sure. So this makes five patches here which gives us much more control of this important change. @dizzy Do you want me or Chad provide patch for 4 or do you want me to do this yourself? I will go on with these based on Chad's patch. -- You are receiving this mail because: You are the assignee for the bug.