From nobody Sat Apr 22 12:01:53 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q3VPG3gpnz46dhf for ; Sat, 22 Apr 2023 12:01:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q3VPG1T2xz3sfG for ; Sat, 22 Apr 2023 12:01:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682164914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9LB+UQdcWdZTNCTRxsMbqllzr7UX334CnTO4uR94mTU=; b=FlLngry84xlJ0M32djj46UpFuNNpJL1MA+hTK01r1yPt0akOAMlcWJ1PLzlynL6oQZNKM5 /8xO2qhvgF/uYpQAxPh3i2rN6T5qQp5Idg1b71lnEinjV22RYgwijqC0vL1nb6FNq+tEsu epX++W4xooZMN+hW721SkWakXa0wWbNWsp1g6lyaVh+OnrbRZ0YfstwGnug5q0uq6FXIfS qp8b4Glav/pa6BtNJfh+Y041qRG3CxjIg6HmMm7rgeHgRcy/pttv8HfGNllK1a+VspEAdq EnQmI+w3PjvWbqzo3Q3g8y05+b7iRACIOnP+6mJGJOSqc23pivgr7ArvWWGMQQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682164914; a=rsa-sha256; cv=none; b=Tb2PsB9yQZmKw57pu+itaURjjdSMH33Tkm6Ig8SlHgIHHqXrda45Wx/2Q8QAI69HjWkec8 R1d/nlfkENbtI5Xw8U7E0OA8t7QL72SyYQoKyS+RVYYvmL9m72gfIw3svHb4D97/Yu77WF 8eaT/xTyyjU2DkXRcWGtdhj/9nabgRzMF2vco8bfAnYgrVOhEDOxwsu2a3y2tGFrvtivAZ 7Q+h/CBvH0DFpoCtdB/jAyBguZW/q9QPbOf9WyBGIQ1D9FaUYrkEMrTx3dQ03t+SHQJOUg /6Oecew2dd5yf6PGoP8ThPYOqpl4vM6fInzaG+t/QE2fIrv+nVpeDB/OBnlLKw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q3VPG0ZRrz11Bc for ; Sat, 22 Apr 2023 12:01:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33MC1snT028729 for ; Sat, 22 Apr 2023 12:01:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33MC1s1s028728 for ports-bugs@FreeBSD.org; Sat, 22 Apr 2023 12:01:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 270989] print/ghostscript10: adds libgs.so; connects to USES and DEFAULT_VERSIONS facilities; flavorized Date: Sat, 22 Apr 2023 12:01:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: diizzy@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270989 --- Comment #2 from Daniel Engberg --- Thanks for the patch, looks good overall but I have a few inputs having a q= uick look at it. Changes to Mk/Uses/ghostscript.mk should go into a separate patch PORTVERSION --> DISTVERSION For overall consistency in tree I'd suggest that we make a nox11 variant ra= ther than x11 and remove base from naming Use ".if ${FLAVOR} =3D=3D nox11" instead of .if !empty(FLAVOR:Mx11) L104 and L105 is a way to do it but I think for the sake of readability its better to wrap it around .if statements --=20 You are receiving this mail because: You are the assignee for the bug.=