[Bug 266564] [NEW PORT] x11/eww: ElKowars wacky widgets

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266564

--- Comment #4 from Jan Beich <jbeich@FreeBSD.org> ---
(In reply to Jesús Daniel Colmenares Oviedo from comment #3)
> * add a patch to fix the correct version of eww in Cargo.lock.

Seems cosmetic. USES=cargo doesn't pass --frozen, so Cargo.lock is
automatically updated from Cargo.toml during build e.g.,

  ===>   Updating Cargo.lock
      Updating eww v0.3.0
(/wrkdirs/usr/ports/x11/eww/work-x11/eww-0.4.0/crates/eww) -> v0.4.0

> +PLIST_FILES=	bin/${PORTNAME}

This can probably moved/grouped under USE_GNOME since that section already has
non-USE* like GH_ACCOUNT.

> I have seen that NixPkg [1] uses that environment variable and I don't know
> much about Nix but I can't understand why/how it can compile eww that way. AUR
> [2] and Alpine [3] does not use that variable, they use nightly.

I did provide examples in other ports. Adding CARGO_ENV=RUSTC_BOOTSTRAP=1 to
Makefile should've been enough (tested in x11/eww myself, even on i386 which is
not supported by lang/rust-nightly). Whether to use CARGO_ENV or MAKE_ENV
doesn't matter as USES=cargo inherits both but if you need to apply
RUSTC_BOOTSTRAP only in certain port options then MAKE_ENV is easier because
there's an option helper while CARGO_ENV would require using generic _VARS +
_VARS_OFF helper.

Note, Firefox has been using RUSTC_BOOTSTRAP for years, see
https://searchfox.org/mozilla-release/search?q=RUSTC_BOOTSTRAP

-- 
You are receiving this mail because:
You are the assignee for the bug.