[Bug 267183] [NEW PORT] games/starfetch: Command line tool that displays constellations

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267183

--- Comment #2 from Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org> ---
(In reply to Nuno Teixeira from comment #1)

Hi!

> REINPLACE_CMD ran, but did not modify file contents: src/starfetch.cpp

This warning is because by default, the value of that variable is
/usr/local/share/starfetch/. Therefore, when sed_checked.sh modifies the
contents of src/starfetch.cpp, it warns because there is no change. But this
warning should disappear when DATADIR is a different path:

With the same DATADIR:
  # make patch
  $ cat work/reinplace_warnings.txt
  - - REINPLACE_CMD ran, but did not modify file contents: src/starfetch.cpp
  $ rg --pcre2 '^string path' work/starfetch-0.0.2/src/starfetch.cpp
  26:string path = "/usr/local/share/starfetch/";

With a different DATADIR:
  # make DATADIR=/tmp/starfetch patch
  $ test -f 'work/reinplace_warnings.txt'; echo $?
  1
  $ rg --pcre2 '^string path' work/starfetch-0.0.2/src/starfetch.cpp
  26:string path = "/tmp/starfetch/";

-- 
You are receiving this mail because:
You are the assignee for the bug.