[Bug 267079] emulators/virtualbox-ose-additions: SAVENAME-related build failure

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 15 Oct 2022 13:27:23 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267079

            Bug ID: 267079
           Summary: emulators/virtualbox-ose-additions: SAVENAME-related
                    build failure
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
               URL: https://cgit.freebsd.org/src/commit/?id=5b5b7e2ca2fa9a
                    2418dd51749f4ef6f881ae7179
                OS: Any
            Status: New
          Keywords: needs-patch
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: vbox@FreeBSD.org
          Reporter: grahamperrin@freebsd.org
             Flags: maintainer-feedback?(vbox@FreeBSD.org)
          Assignee: vbox@FreeBSD.org
             Flags: maintainer-feedback?

Via the most recent report at
<https://portsfallout.com/fallout?port=emulators%2Fvirtualbox-ose-additions>,
from
<https://lists.freebsd.org/archives/freebsd-pkg-fallout/2022-October/280835.html>: 


----
…
/wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11-legacy/work/VirtualBox-5.2.44/src/VBox/Additions/freebsd/vboxvfs/vboxvfs_vnops.c:1304:22:
error: use of undeclared identifier 'SAVENAME'; did you mean 'RENAME'?
                                cnp->cn_flags |= SAVENAME;
                                                 ^~~~~~~~
                                                 RENAME
/usr/src/sys/sys/namei.h:44:40: note: 'RENAME' declared here
enum nameiop { LOOKUP, CREATE, DELETE, RENAME };
                                       ^
3 warnings and 1 error generated.
…
----


5b5b7e2ca2fa9a2418dd51749f4ef6f881ae7179 (2022-09-17) was: 

> vfs: always retain path buffer after lookup
> 
> This removes some of the complexity needed to maintain HASBUF and
> allows for removing injecting SAVENAME by filesystems.

<https://reviews.freebsd.org/D36542> additionally summarises: 

> … Ultimately both flags get retired.

-- 
You are receiving this mail because:
You are the assignee for the bug.