[Bug 267938] security/heimdal no longer requires devel/llvm${LLVM_DEFAULT} to build/run

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 23 Nov 2022 00:23:44 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267938

            Bug ID: 267938
           Summary: security/heimdal no longer requires
                    devel/llvm${LLVM_DEFAULT} to build/run
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: hrs@FreeBSD.org
          Reporter: dewayne@heuristicsystems.com.au
             Flags: maintainer-feedback?(hrs@FreeBSD.org)
          Assignee: hrs@FreeBSD.org

Created attachment 238268
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=238268&action=edit
Modified to use CLANG_FORMAT="" rather than no, which it tries to execute

Tatsuki Makino suggested some options at
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267814#c28
which removes the need for clang-format and the need to build llvm90.  This
change removes the heimdal build scripts' incorrect attempt to run "no".

I'd reviewed one case where clang-format was used.  It was to tidy machine
generated C code that was very difficult to read. If you are wish to debug
heimdal then it is recommended to remove the changes included in this patch
update, and  enable building of clang-format via an earlier than installed
version of clang (on FBSD12.4Pre clang 13.0 is used)

For the more general case, I've attached an update of
heimdal/files/patch-configure to implement Tatsuki's last option
-  test -z "$ac_cv_prog_CLANG_FORMAT" && ac_cv_prog_CLANG_FORMAT="no"
+  test -z "$ac_cv_prog_CLANG_FORMAT" && ac_cv_prog_CLANG_FORMAT=""
with thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.