[Bug 263090] www/node14: Update to 14.19.3 (includes security fixes)

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 26 May 2022 00:48:00 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263090

--- Comment #6 from Derek Schrock <dereks@lifeofadishwasher.com> ---
(In reply to Kubilay Kocak from comment #4)

> - Are there performance implications for the ssl patch to node.gyp?

There shouldn't be.  This is a previous patch reworked for 14.19.x codebase.
https://cgit.freebsd.org/ports/tree/www/node14/files/patch-node.gypi?id=0464754ea1f56c60d43945f6da2d9127a6a80527

> - What is the nature of the COREPACK additional (by default), as it relates to and compares to existing functionality of the ports current version?

From my understanding corepack is taking third-party package managers and
building them into by a proxy such that don't need to be installed else where. 
I don't want to say it's the same thing but kinda of ensurepipish...? 

This is experimental feature and I wanted to disable to by default however
given that www/node16 enabled it by default I figured we would follow suit
here.

> - Depending on the build system design, CONFIGURE_* options can be non deterministic, and there is no CONFIGURE_ON to match the CONFIGURE_OFF addition here.
> Did you try COREPACK_CONFIGURE_WITH=corepack? 


There isn't a --with-corepack in node configure script so I believe that's why
it's _OFF only and not a _WITH.

$ ./configure --with-corepack ; echo $?
Node.js configure: Found Python 3.8.13...
Usage: configure [options]

configure: error: no such option: --with-corepack
2

So unless if upstream changes the script I don't with a _WITH would work here.

-- 
You are receiving this mail because:
You are the assignee for the bug.