[Bug 264225] security/keepassxc: Fix build on recent head (after lld 14 import)

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 25 May 2022 08:17:21 UTC

            Bug ID: 264225
           Summary: security/keepassxc: Fix build on recent head (after
                    lld 14 import)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: lwhsu@FreeBSD.org
          Reporter: madpilot@FreeBSD.org
             Flags: maintainer-feedback?(lwhsu@FreeBSD.org)
          Assignee: lwhsu@FreeBSD.org

Created attachment 234197
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=234197&action=edit
patch v1


I upgraded to latest head and keepassxc now fails to build.

Attached patch addresses the issue. I did not make it conditional on the OS
version because it seems to make no difference.

The problem is lld refusing an option which it was accepting but I could not
find any documentation for, so I guess it was a compatibility nop before.

on 13.1:

> ld --no-add-needed
ld: error: no input files

on head after 1400059:

> ld --no-add-needed
ld: error: unknown argument '--no-add-needed'

so my patch simply removes that option from the command line.

If required I can make it depend on __FreeBSD_version, by moving from a patch
to a reinplace command in the Makefile, but as I said it looks like this linker
option is actually a nop.

You are receiving this mail because:
You are the assignee for the bug.