[Bug 264084] shells/rc missing files when upgrading

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264084

Chris Hutchinson <portmaster@bsdforge.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |portmaster@bsdforge.com

--- Comment #2 from Chris Hutchinson <portmaster@bsdforge.com> ---
Created attachment 234067
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=234067&action=edit
patch to deinstallation problem for shells/rc

The error(s) reported are harmless. While I'm not
the Maintainer. I was the last one to touch this.
The changes I made largely carried the previous
policies forward.
However, now that you report these errors. I took
a closer look and discovered that one of those policies
was wrong. It's effectively the same error. Just repeated
for every missing link.

Problem:
The patch file used with this port hard links [ln(1)]
one file to several additional files by other names. Which
means once the target is removed all the links (correctly)
complain.

Solution:
While I probably could have created Soft links instead.
I simply chose to make literal copies for each of the
needed named files.
This is what the attached diff provides. It also replaces
the previous patch.

Sample output after patching and installing 1.7.4_2.
Then patching 1.7.4_3 and attempting an upgrade:

dev@portsdev $ make -DBATCH deinstall && make -DBATCH install
===>  Deinstalling for rc
===>   Deinstalling rc-1.7.4_2
Updating database digests format: 100%
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages
in the universe):

Installed packages to be REMOVED:
        rc: 1.7.4_2

Number of packages to be removed: 1

The operation will free 3 MiB.
[portsdev.localhost] [1/1] Deinstalling rc-1.7.4_2...
[portsdev.localhost] [1/1] Deleting files for rc-1.7.4_2: 100%
===>  Installing for rc-1.7.4_3
===>  Checking if rc is already installed
===>   Registering installation for rc-1.7.4_3
[portsdev.localhost] Installing rc-1.7.4_3...

dev@portsdev $

Problem solved.

@Maintainer/committer
If the Maintainer is no longer able/willing to continue maintaining
this port. Feel free to name me as Maintainer.

That's it.

Thanks!

Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.