[Bug 264064] games/devilutionX: update to 1.4

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264064

            Bug ID: 264064
           Summary: games/devilutionX: update to 1.4
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: eduardo@FreeBSD.org
          Reporter: amdmi3@FreeBSD.org
          Assignee: eduardo@FreeBSD.org
             Flags: maintainer-feedback?(eduardo@FreeBSD.org)

Created attachment 234016
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=234016&action=edit
Patch

- Update to 1.4
- Make dependency handling less obscure and save a line by dropping _MY_DEPENDS
- Drop unnecessary .desktop file patches
- Install from the port, be more explicit and flexible
- Convert to pkg-plist as there's more files now
- The new version tries to fetch dependencies from the net, for some
depenencies this is unconditional. Fetch these properly with GH_TUPLE and place
in a directory where CMake expectes them.
- Upstream code expects patch component in the version, so add an extra .0 to
VERSION_NUM. This should not break on (future) X.Y.Z versions as the component
will move to micropatch and be ignored
- BINARY_RELEASE option is gone
- Untie DEBUG (engine debug bode) from WITH_DEBUG knob (build debug binary),
these are orthogonal
- Properly support optional depends; zerotier is the only one broken as it
conflicts with system header (see
https://github.com/diasurgical/devilutionX/issues/4585)
- Install devilutionx (own) data file
  - Since it's not versioned, use a little hack to add a tag to the filename to
avoid clashes on the future updates; this seemed less evil than introducing
DIST_SUBDIR
  - Use two-level datadir to be consistent with ~/.local/share path (however I
vouch for converting both for single level)
- Update pkg-message (Diablo data file doesn't have to be lowercase, works
either way)

QA: reprise
SUCCESS games/devilutionX on 13-amd64
SUCCESS games/devilutionX on 13-amd64 (+DEBUG)
SUCCESS games/devilutionX on 13-amd64 (-LTO)
SUCCESS games/devilutionX on 13-amd64 (-SOUND)
SUCCESS games/devilutionX on 13-amd64 (+TEST)
SUCCESS games/devilutionX on 13-amd64 (-ENCRYPTION)
SUCCESS games/devilutionX on 13-amd64 (-NETWORK)
SUCCESS games/devilutionX on 13-amd64 (-TCP)
SKIPPED games/devilutionX on 13-amd64 (+ZEROTIER)
        * is marked as broken: does not build: fatal error:
'sys/appleapiopts.h' file not found
SUCCESS games/devilutionX on 13-amd64 (-NETWORK -TCP -ENCRYPTION)

Poudriere:
SUCCESS on 12-i386
SUCCESS on 12-amd64
SUCCESS on 13-i386
SUCCESS on 13-amd64
SUCCESS on 13-amd64:noport

-- 
You are receiving this mail because:
You are the assignee for the bug.