[Bug 261638] Mk/Uses/bdb.mk: Many ports IGNORE'd with BDB_DEFAULT=18: cannot install: no eligible BerkeleyDB version

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 16 May 2022 16:31:37 UTC

John Hein <jcfyecrayz@liamekaens.com> changed:

           What    |Removed                     |Added
                 CC|                            |bdrewery@FreeBSD.org,
                   |                            |jcfyecrayz@liamekaens.com,
                   |                            |perl@FreeBSD.org

--- Comment #3 from John Hein <jcfyecrayz@liamekaens.com> ---
Note: bdrewery@ added the following to Mk/Uses/bdb.mk:

commit a396e4f131341b58bf897f73d1ce1f8a6f6e5256
Author:     Bryan Drewery <bdrewery@FreeBSD.org>
AuthorDate: Mon May 9 11:56:31 2022 -0700
Commit:     Bryan Drewery <bdrewery@FreeBSD.org>
CommitDate: Mon May 9 11:58:30 2022 -0700

    Mk/Uses/bdb.mk: Allow bdb:18 to work by default.

    mail/mutt currently has USES=bdb:18 which causes an obscure error in
    Poudriere causing it to be IGNORED unless WITH_BDB6_PERMITTED is set.
    We already have a license framework so this flag seems odd but in the
    case where a port explicitly is asking for the version it makes sense
    to permit it as the default.

diff --git a/Mk/Uses/bdb.mk b/Mk/Uses/bdb.mk
index 645b9e9a7b0e..0316ff061229 100644
--- a/Mk/Uses/bdb.mk
+++ b/Mk/Uses/bdb.mk
@@ -63,7 +63,7 @@ _DB_DEFAULTS= 5
 #   Since 2020-12-02, this name is not fitting too much but
 #   retained for now for compatibility. The name of this variable
 #   is subject to change especially once db6 were removed.
-.  if defined(WITH_BDB6_PERMITTED)
+.  if defined(WITH_BDB6_PERMITTED) || ${_bdb_ARGS} == 18
 .  endif

Unfortunately, the LICENSE for db18 is AvGPL3.  This can cause a port that uses
this version of bdb to now be "infected" by this license and may require the
LICENSE setting for the port to be adjusted.

This is not fully in sync with the OP's original issue, but it is intimately
related to one solution for it (define WITH_BDB6_PERMITTED=1).  This may
require discussion in a separate bug or phab review.

bdrewery@ CC'd for comment.

Any port that now uses something newer than db5 (which, in the current ports
tree, means using databases/db18) may need to adjust its declared LICENSE.

See also mail/mutt: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263211

See also databases/p5-BerkeleyDB (perl@ CC'd - please comment).

You are receiving this mail because:
You are on the CC list for the bug.