[Bug 262814] converters/wkhtmltopdf: fix build with clang 14, by future-proofing compiler version check

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262814

            Bug ID: 262814
           Summary: converters/wkhtmltopdf: fix build with clang 14, by
                    future-proofing compiler version check
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: pi@FreeBSD.org
          Reporter: dim@FreeBSD.org
             Flags: maintainer-feedback?(pi@FreeBSD.org)
          Assignee: pi@FreeBSD.org

During an exp-run for llvm 14 (see bug 261742), it turned out that
converters/wkhtmltopdf fails to build with clang 14:

c++ -Wl,-rpath=/usr/local/lib/gcc8 -Wl,-O1 -pthread -shared
-Wl,-soname,libwkhtmltox.so.0 -o libwkhtmltox.so.0.12.6 loadsettings.o
logging.o multipageloader.o tempfile.o converter.o websettings.o reflect.o
utilities.o pdfsettings.o pdfconverter.o outline.o tocstylesheet.o
imagesettings.o imageconverter.o pdf_c_bindings.o image_c_bindings.o
moc_multipageloader_p.o moc_converter_p.o moc_pdfconverter_p.o
moc_imageconverter_p.o moc_pdf_c_bindings_p.o moc_image_c_bindings_p.o
moc_converter.o moc_multipageloader.o moc_utilities.o moc_pdfconverter.o
moc_imageconverter.o qrc_wkhtmltopdf.o   -L/usr/local/lib
-L/wrkdirs/usr/ports/converters/wkhtmltopdf/work/wkhtmltopdf-0.12.6/build/qt/lib
-L/wrkdirs/usr/ports/converters/wkhtmltopdf/work/wkhtmltopdf-0.12.6/build/qt/plugins/codecs
-lqcncodecs
-L/wrkdirs/usr/ports/converters/wkhtmltopdf/work/wkhtmltopdf-0.12.6/build/qt/lib
-L/usr/local/lib -lqjpcodecs -lqkrcodecs -lqtwcodecs -lQtWebKit -lQtSvg
-lQtXmlPatterns -lQtGui -ljpeg -lpng -lXrender -lfontconfig -lfreetype -lXext
-lX11 -lQtNetwork -lssl -lcrypto -lQtCore -lz -lm
ld: error: unable to find library -lQtWebKit
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[2]: *** [Makefile:164: ../../bin/libwkhtmltox.so.0.12.6] Error 1

Ultimately this is caused by incorrect compiler version detection in
wkhtmltopdf's configure script. Something similar was fixed for clang 12 in
ports commit 1049d80399ac327964eca41e4188f988430c5f7c, and later for clang 13
in ports commit ad5fedf36832fd7e2447d8c4cb6b54128a2fcb20.

I would to propose fixing this for a long time, and for most possible version
numbers, so this exercise won't have to be repeated again and again if we
upgrade compilers. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.