[Bug 262489] security/duo: incorrect paths in man pages

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262489

            Bug ID: 262489
           Summary: security/duo: incorrect paths in man pages
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: zi@FreeBSD.org
          Reporter: andrew.daugherity@gmail.com
             Flags: maintainer-feedback?(zi@FreeBSD.org)
          Assignee: zi@FreeBSD.org

The man pages for login_duo(8) and pam_duo(8) state that the default config
file path is /usr/local/etc/duo/{login,pam}_duo.conf but that is incorrect --
the port configures it with '--sysconfdir=${PREFIX}/etc' aka /usr/local/etc. 
(The upstream default sysconfdir [1] is /etc/duo, not /etc!)

Sample config files are installed into /usr/local/etc and when properly
configured, Duo does indeed work with files in this location.

Additionally, login_duo(8) refers to /usr/local/etc/motd and pam_duo(8) refers
to /usr/local/etc/passwd, both of which are obviously incorrect.

I believe these are both caused by the ${REINPLACE_CMD} -e 's| /etc|
${PREFIX}/etc|g' in the port Makefile.  I think that changing this to
's|/etc/duo|${PREFIX}/etc|g' should fix both issues, namely:
- stripping the duo subdir, i.e. /etc/duo =>  /usr/local/etc
- not matching top-level /etc files like motd and passwd


[1]
https://github.com/duosecurity/duo_unix/blob/5b1f55e06c1760f32c541c8d8ae56b78c2cbfa1d/configure.ac#L26

-- 
You are receiving this mail because:
You are the assignee for the bug.