[Bug 264699] [NEW PORT] textproc/libxml++50: XML API for C++

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264699

Daniel Engberg <diizzy@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |diizzy@FreeBSD.org

--- Comment #4 from Daniel Engberg <diizzy@FreeBSD.org> ---
PORTVERSION --> DISTVERSION (Suggested by Porters Handbook)
Add GNOME to MASTER_SITES (alias)
libxml2 dependency should use USE_GNOME [1]
Please soft USES in alphabetical order
Why are we overriding upstream -std=c++17?
Do we need a static lib?

fwiw, BINARY_ALIAS is a one line patch (already fixed in upstream)
https://github.com/libxmlplusplus/libxmlplusplus/blob/master/meson.build#L48
I'd rather see we fixing it here instead of adding workarounds

PLIST_SUB, you can probably be a bit more create and use ${DISTVERSION:R}?

You probably want to add options for building unit tests (which works so don't
disable permanently)

[1]: https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.