[Bug 265291] x11-wm/fvwm3- FvwmIconMan module crashes on FreeBSD 13 in virtual machine

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 18 Jul 2022 23:29:53 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265291

--- Comment #1 from Felix Palmen <felix@palmen-it.de> ---
Created attachment 235341
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=235341&action=edit
fvwm3 FvwmIconMan test patch

I'm using fvwm3-1.0.4 myself on 13.1-RELEASE, and I have FvwmIconMan as a part
of my taskbar, and never had problems. I also believe it's unlikely that
running in a VM could have any effect. What's quite likely is that
configuration (especially of FvwmIconMan itself) matters, depending on it,
you're hitting different code paths and just one of them might have a bug. Did
you do a careful comparison between your two machines?

Technically, from your stacktrace, I assume what's immediately leading to the
crash is an uninitialized field in the struct here:
https://github.com/fvwmorg/fvwm3/blob/1.0.4/modules/FvwmIconMan/x.c#L743

Could you please test the attached patch?

It just initializes the offending field to NULL, probably not what that code
should do, but if it avoids the crash, you can pass it upstream as a hint for
them to find the *correct* solution...

-- 
You are receiving this mail because:
You are the assignee for the bug.